Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2024 Massachusetts Income Tax Parameters #5564

Open
wants to merge 35 commits into
base: master
Choose a base branch
from

Conversation

DTrim99
Copy link
Collaborator

@DTrim99 DTrim99 commented Feb 5, 2025

Fixes #5562

@DTrim99 DTrim99 marked this pull request as draft February 5, 2025 19:55
@DTrim99
Copy link
Collaborator Author

DTrim99 commented Feb 5, 2025

I changed the name of the "dependent credit" folder to "child and family tax credit." Do I need to change anything in the Python files?

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.10%. Comparing base (75cc11e) to head (2b093e5).
Report is 53 commits behind head on master.

Files with missing lines Patch % Lines
...able_income/ma_part_b_taxable_income_deductions.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5564      +/-   ##
==========================================
- Coverage   99.10%   99.10%   -0.01%     
==========================================
  Files        2687     2695       +8     
  Lines       38934    39028      +94     
  Branches      170      173       +3     
==========================================
+ Hits        38585    38677      +92     
- Misses        315      316       +1     
- Partials       34       35       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DTrim99 DTrim99 requested review from daphnehanse11 and removed request for PavelMakarchuk February 5, 2025 22:44
@DTrim99 DTrim99 self-assigned this Feb 6, 2025
@DTrim99 DTrim99 marked this pull request as ready for review February 6, 2025 02:49
description: The Massachusetts interest exemption is in effect if this is true.

values:
2002-01-01: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source for it coming into effect in 2002?

@@ -1,19 +1,19 @@
from policyengine_us.model_api import *


class ma_dependent_credit(Variable):
class ma_child_and_family(Variable):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class ma_child_and_family(Variable):
class ma_child_and_family_credit(Variable):

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename file and test file as well

@@ -108,7 +108,7 @@
state_code: MA
members: [child_1, child_2, child_3]
output:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to adjust test outputs

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the name to ma_child_and_family_credit or change the actual number output?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the output variable name to ma_child_and_family_credit

@@ -1,7 +1,7 @@
- name: 2022 max of the credits.
period: 2022
input:
ma_dependent_credit: 1
ma_child_and_family: 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adjust inputs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update 2024 Massachusetts Income Tax Parameters
4 participants