-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 2024 District of Columbia Income Tax Parameters #5567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5567 +/- ##
========================================
Coverage 99.10% 99.10%
========================================
Files 2687 2695 +8
Lines 38934 39035 +101
Branches 170 172 +2
========================================
+ Hits 38585 38686 +101
Misses 315 315
Partials 34 34 ☔ View full report in Codecov by Sentry. |
PavelMakarchuk
requested changes
Feb 17, 2025
policyengine_us/parameters/gov/states/dc/tax/income/subtractions/sources.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/dc/tax/income/credits/ptc/fraction_nonelderly.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/dc/tax/income/credits/ptc/fraction_nonelderly.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/dc/tax/income/credits/ptc/fraction_elderly.yaml
Outdated
Show resolved
Hide resolved
daphnehanse11
approved these changes
Feb 17, 2025
daphnehanse11
approved these changes
Feb 17, 2025
PavelMakarchuk
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last minor comment
policyengine_us/parameters/gov/states/dc/tax/income/credits/kccatc/income_limit.yaml
Show resolved
Hide resolved
MaxGhenis
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5563