Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structural reforms for Rep Jared Golden's FISC #5601

Merged
merged 18 commits into from
Feb 19, 2025

Conversation

PavelMakarchuk
Copy link
Collaborator

Fixes #5596

@PavelMakarchuk PavelMakarchuk marked this pull request as ready for review February 15, 2025 01:47
Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add the >=18yo requirement for caregivers too, or file as a separate issue if not here?

Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This o1-pro conversation revealed other changes needed:

  1. Reorder the steps:

    • Compute the base monthly amount (pregnancy or child rate).
    • Apply the 20% “joint” marriage bonus on top of that.
    • Subtract the phase‐out amounts.
    • Enforce the 1/12‐of‐AGI cap last.
  2. Adjust the phase‐out:

    • The bill’s $16.67 per $1,000 is per month. If the code is doing an annual calculation, multiply the phase‐out rate by 12 so you reduce $200 annually per $1,000 above the threshold.
  3. Fix the 1/12‐of‐AGI cap:

    • Currently, the entire annual credit is capped at 1/12 of AGI. Instead, either (a) limit each monthly payment to AGI/12, or (b) allow up to a total of AGI if summing twelve monthly checks across the year.

@PavelMakarchuk
Copy link
Collaborator Author

This o1-pro conversation revealed other changes needed:

  1. Reorder the steps:

    • Compute the base monthly amount (pregnancy or child rate).
    • Apply the 20% “joint” marriage bonus on top of that.
    • Subtract the phase‐out amounts.
    • Enforce the 1/12‐of‐AGI cap last.
  2. Adjust the phase‐out:

    • The bill’s $16.67 per $1,000 is per month. If the code is doing an annual calculation, multiply the phase‐out rate by 12 so you reduce $200 annually per $1,000 above the threshold.
  3. Fix the 1/12‐of‐AGI cap:

    • Currently, the entire annual credit is capped at 1/12 of AGI. Instead, either (a) limit each monthly payment to AGI/12, or (b) allow up to a total of AGI if summing twelve monthly checks across the year.

modified the phase-out and cap to be yearly params to simplify

@PavelMakarchuk PavelMakarchuk removed the request for review from MaxGhenis February 17, 2025 10:43
@PavelMakarchuk PavelMakarchuk marked this pull request as draft February 17, 2025 10:43
@PavelMakarchuk PavelMakarchuk marked this pull request as ready for review February 18, 2025 12:40
Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's simplify by putting the pregnancy amount (4mo) in the 0yo

Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add an integration test without is_mother as True, i want to make sure the pregnancy credit applies when we just have a single parent of unspecified gender. if it adds complexity just remove the separate pregnancy amount and make the 0yo bracket $8k

@PavelMakarchuk
Copy link
Collaborator Author

add an integration test without is_mother as True, i want to make sure the pregnancy credit applies when we just have a single parent of unspecified gender. if it adds complexity just remove the separate pregnancy amount and make the 0yo bracket $8k

consolidated into one parameter and one amount variable - the is mother doe snot apply automatically to single parents

@MaxGhenis MaxGhenis merged commit 260ef2b into master Feb 19, 2025
3 checks passed
@MaxGhenis MaxGhenis deleted the PavelMakarchuk/issue5596 branch February 19, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Structural reforms for Rep Jared Golden's FISC
2 participants