Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize code for region selection and subsampling #63

Open
nikhilwoodruff opened this issue Dec 17, 2024 · 0 comments
Open

Modularize code for region selection and subsampling #63

nikhilwoodruff opened this issue Dec 17, 2024 · 0 comments

Comments

@nikhilwoodruff
Copy link
Contributor

          __suggestion:__ Modularize code for region selection and subsampling

This code feels a bit duplicative, and I'm wondering if these couldn't be functions, something like apply_subsample and apply_region. This would also prevent any possible future bug associated with modifying one piece of the code and accidentally forgetting the other.

This could also be a future thing, don't want to block where not necessary.

Originally posted by @anth-volk in #62 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant