New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protocol on_error called twice for the same issue #124

Open

progovoy opened this issue Dec 1, 2016 · 1 comment

progovoy commented Dec 1, 2016 •

edited

Loading

Steps to reproduce on aioamqp 0.8.2:

Just kill rabbitmq and you'll see that the error callback is called twice

Did not investigated it but, this happens because _close_channels in protocol.py is called on connection lost and on AmqpClosedConncetion exception.

Desired behavior:
on connection error I would expect my callback to be called once to be able to handle reconnection properly.

Contributor

RemiCardona commented Mar 23, 2017

This will be dealt with as part of the API redesign of #118. This callback (like most/all others) is most likely going to be removed altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment