Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel.basic_server_ack doesn't respect multiple flag #233

Open
alexchamberlain opened this issue Mar 30, 2022 · 3 comments
Open

Channel.basic_server_ack doesn't respect multiple flag #233

alexchamberlain opened this issue Mar 30, 2022 · 3 comments

Comments

@alexchamberlain
Copy link

When using publisher confirms, the broker may use the multiple flag to indicate that any delivery tag less than the one specified should be considered acknowledged, but that isn't being respected by basic_server_ack at the moment. This leads futures that are not resolved by the library.
@RemiCardona
Copy link
Contributor

Just to be 100% sure, did you try this on 0.15.0b1? I don't remember merging anything related to acks but just in case…

@alexchamberlain
Copy link
Author

I did not, but the latest code on master doesn't refer to frame.multiple, so I don't think it's handled.

@RemiCardona
Copy link
Contributor

I'm not familiar with that feature. Do you have any sample code/configuration that shows the bad behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RemiCardona @alexchamberlain