From f784cb26d8ff88e06ad2ed39d652ad8168379719 Mon Sep 17 00:00:00 2001 From: Kyle Gerard Felker Date: Mon, 1 Apr 2024 13:30:41 -0500 Subject: [PATCH 1/4] Bump version to v24.0 --- src/main.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main.cpp b/src/main.cpp index 3a72d4ce6..842e32bb2 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -63,7 +63,7 @@ //! \brief Athena++ main program int main(int argc, char *argv[]) { - std::string athena_version = "version 21.0 - January 2021"; + std::string athena_version = "version 24.0 - April 2024"; char *input_filename = nullptr, *restart_filename = nullptr; char *prundir = nullptr; int res_flag = 0; // set to 1 if -r argument is on cmdline From 3691ec2fdeeca1eaa26be7f9e98c9856c1163a13 Mon Sep 17 00:00:00 2001 From: Kyle Gerard Felker Date: Mon, 1 Apr 2024 13:53:26 -0500 Subject: [PATCH 2/4] Add v24.0 Release Notes to CHANGELOG --- CHANGELOG.md | 120 ++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 119 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 84baacd4d..2c0f4b5a1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,7 +16,125 @@ The automatically-generated content should be used for reference when writing th ## [Unreleased](https://github.com/PrincetonUniversity/athena/tree/HEAD) -[Full Changelog](https://github.com/PrincetonUniversity/athena/compare/v21.0...HEAD) +[Full Changelog](https://github.com/PrincetonUniversity/athena/compare/v24.0...HEAD) + +## [v24.0](https://github.com/PrincetonUniversity/athena/tree/v24.0) (2024-04-01) + +[Full Changelog](https://github.com/PrincetonUniversity/athena/compare/v21.0...v24.0) + +**Implemented enhancements:** + +- Remove unused DEBUG macro [\#531](https://github.com/PrincetonUniversity/athena/issues/531) +- Make DEBUG macro a binary 1/0 instead of string [\#533](https://github.com/PrincetonUniversity/athena/pull/533) ([felker](https://github.com/felker)) +- Update cpplint.py [\#524](https://github.com/PrincetonUniversity/athena/pull/524) ([felker](https://github.com/felker)) +- Add Jenkins script on stellar [\#517](https://github.com/PrincetonUniversity/athena/pull/517) ([changgoo](https://github.com/changgoo)) +- Chemistry update units [\#489](https://github.com/PrincetonUniversity/athena/pull/489) ([changgoo](https://github.com/changgoo)) +- Updated Python scripts [\#471](https://github.com/PrincetonUniversity/athena/pull/471) ([c-white](https://github.com/c-white)) +- Make turbulent velocity field resolution independent [\#461](https://github.com/PrincetonUniversity/athena/pull/461) ([sanghyukmoon](https://github.com/sanghyukmoon)) +- Added error message for rotating frame in 1d spherical polar [\#424](https://github.com/PrincetonUniversity/athena/pull/424) ([msbc](https://github.com/msbc)) +- Clarify units in EOS input file [\#423](https://github.com/PrincetonUniversity/athena/pull/423) ([msbc](https://github.com/msbc)) +- Add hydro and MHD regression tests for quirk.cpp [\#386](https://github.com/PrincetonUniversity/athena/pull/386) ([felker](https://github.com/felker)) +- Prepare to open-source the development repository [\#361](https://github.com/PrincetonUniversity/athena/pull/361) ([felker](https://github.com/felker)) +- Fix the switch to default RKL2 STS [\#350](https://github.com/PrincetonUniversity/athena/pull/350) ([pdmullen](https://github.com/pdmullen)) +- Minor update of shearing box [\#348](https://github.com/PrincetonUniversity/athena/pull/348) ([tomo-ono](https://github.com/tomo-ono)) + +**Fixed bugs:** + +- Timestep is incorrect for some GR metrics [\#545](https://github.com/PrincetonUniversity/athena/issues/545) +- Is this pdata-\>pnext supposed to be pnew-\>pnext here? [\#528](https://github.com/PrincetonUniversity/athena/issues/528) +- AMR in GR Does Not Work \(Undefined Behavior\) [\#475](https://github.com/PrincetonUniversity/athena/issues/475) +- Small bug in specifying uov output [\#436](https://github.com/PrincetonUniversity/athena/issues/436) +- MPI disk simulations hang on Berkeley's Savio cluster [\#430](https://github.com/PrincetonUniversity/athena/issues/430) +- Wrong density used for relativistic passive scalar prolongation [\#419](https://github.com/PrincetonUniversity/athena/issues/419) +- h5py 3.x releases causes issues with plot\_slice.py [\#393](https://github.com/PrincetonUniversity/athena/issues/393) +- Numerical artifacts in the gr\_torus problem [\#381](https://github.com/PrincetonUniversity/athena/issues/381) +- Shear flag is set to false for all corner neighbors [\#377](https://github.com/PrincetonUniversity/athena/issues/377) +- HLLC can get NaNs [\#352](https://github.com/PrincetonUniversity/athena/issues/352) +- 4th order reconstruction and outflow BCs bug [\#298](https://github.com/PrincetonUniversity/athena/issues/298) +- Add more runtime NGHOST checks \(especially for SMR/AMR\) [\#163](https://github.com/PrincetonUniversity/athena/issues/163) +- GR-AMR incompatibility [\#64](https://github.com/PrincetonUniversity/athena/issues/64) +- Fix x1v for Curvilinear+PPM [\#566](https://github.com/PrincetonUniversity/athena/pull/566) ([forrestglines](https://github.com/forrestglines)) +- Remove all possibly extraneous DeleteAthenaArray calls [\#560](https://github.com/PrincetonUniversity/athena/pull/560) ([felker](https://github.com/felker)) +- Fixed Typo in Error Messages [\#557](https://github.com/PrincetonUniversity/athena/pull/557) ([Rgokemeijer](https://github.com/Rgokemeijer)) +- Miscellaneous small fixes [\#549](https://github.com/PrincetonUniversity/athena/pull/549) ([c-white](https://github.com/c-white)) +- Add trap for MHD with xorder=4,4c selections [\#535](https://github.com/PrincetonUniversity/athena/pull/535) ([felker](https://github.com/felker)) +- Suppress 2x ICX default warnings [\#532](https://github.com/PrincetonUniversity/athena/pull/532) ([felker](https://github.com/felker)) +- Stop accessing a deleted pointer [\#529](https://github.com/PrincetonUniversity/athena/pull/529) ([felker](https://github.com/felker)) +- Fix a potential bug in the characteristic projection [\#497](https://github.com/PrincetonUniversity/athena/pull/497) ([bcaddy](https://github.com/bcaddy)) +- Fix an indexing bug in x3v in disk.cpp [\#458](https://github.com/PrincetonUniversity/athena/pull/458) ([tomo-ono](https://github.com/tomo-ono)) +- Change SMALL\_NUMBER to 10^-4 in the HLLD-series Riemann solvers [\#457](https://github.com/PrincetonUniversity/athena/pull/457) ([tomidakn](https://github.com/tomidakn)) +- Fix hang when using shearing box + STS [\#456](https://github.com/PrincetonUniversity/athena/pull/456) ([pdmullen](https://github.com/pdmullen)) +- Apply output time cadence changes even if no input file is provided during restarts [\#454](https://github.com/PrincetonUniversity/athena/pull/454) ([felker](https://github.com/felker)) +- Fixing the restart error reported in \#449 [\#453](https://github.com/PrincetonUniversity/athena/pull/453) ([tomidakn](https://github.com/tomidakn)) +- Fixed bug in fixup routine for SRMHD [\#452](https://github.com/PrincetonUniversity/athena/pull/452) ([c-white](https://github.com/c-white)) +- Fixed passive scalar + AMR bug [\#446](https://github.com/PrincetonUniversity/athena/pull/446) ([c-white](https://github.com/c-white)) +- Initialize pointer fv\_new\_ to nullptr [\#445](https://github.com/PrincetonUniversity/athena/pull/445) ([kahoooo](https://github.com/kahoooo)) +- Fix bug specifying uov output [\#440](https://github.com/PrincetonUniversity/athena/pull/440) ([kahoooo](https://github.com/kahoooo)) +- Fix dependency of passive scalar boundary communication [\#434](https://github.com/PrincetonUniversity/athena/pull/434) ([tomo-ono](https://github.com/tomo-ono)) +- Fixed typo in gr\_torus problem generator [\#431](https://github.com/PrincetonUniversity/athena/pull/431) ([c-white](https://github.com/c-white)) +- Tiny fix for reading Schwarzschild .athdf files [\#425](https://github.com/PrincetonUniversity/athena/pull/425) ([c-white](https://github.com/c-white)) +- Corrected density used in relativistic passive scalar prolongation [\#420](https://github.com/PrincetonUniversity/athena/pull/420) ([c-white](https://github.com/c-white)) +- Extend the x2 loop limit by 1 for x3 outflow outer bc [\#404](https://github.com/PrincetonUniversity/athena/pull/404) ([felker](https://github.com/felker)) +- Update plotting slices and add polar projection view [\#394](https://github.com/PrincetonUniversity/athena/pull/394) ([kurtsansom](https://github.com/kurtsansom)) +- Fixed typo in GR Bondi problem generator [\#385](https://github.com/PrincetonUniversity/athena/pull/385) ([c-white](https://github.com/c-white)) +- Fix of bug in the strat pgen for a restart run [\#384](https://github.com/PrincetonUniversity/athena/pull/384) ([tomo-ono](https://github.com/tomo-ono)) +- Fix typo in setting of shearing boundary flag [\#379](https://github.com/PrincetonUniversity/athena/pull/379) ([tomo-ono](https://github.com/tomo-ono)) +- Fix shearing boundary flag for corner neighbors [\#378](https://github.com/PrincetonUniversity/athena/pull/378) ([tomo-ono](https://github.com/tomo-ono)) +- Fix a bug in OA hydro source term [\#368](https://github.com/PrincetonUniversity/athena/pull/368) ([tomo-ono](https://github.com/tomo-ono)) +- Correct calculations of the energy viscous flux [\#363](https://github.com/PrincetonUniversity/athena/pull/363) ([tomo-ono](https://github.com/tomo-ono)) +- Fix a bug in history output again [\#360](https://github.com/PrincetonUniversity/athena/pull/360) ([kahoooo](https://github.com/kahoooo)) +- Fix a bug that takes up unnecessary space in restart file [\#358](https://github.com/PrincetonUniversity/athena/pull/358) ([kahoooo](https://github.com/kahoooo)) +- Fix a bug in history output [\#357](https://github.com/PrincetonUniversity/athena/pull/357) ([kahoooo](https://github.com/kahoooo)) +- Make variables used in simd loops private [\#355](https://github.com/PrincetonUniversity/athena/pull/355) ([pgrete](https://github.com/pgrete)) +- Don't load conserved variables into additional buffers from .rst [\#353](https://github.com/PrincetonUniversity/athena/pull/353) ([felker](https://github.com/felker)) +- Fix 4th-order hydro with non-periodic BCs [\#347](https://github.com/PrincetonUniversity/athena/pull/347) ([pdmullen](https://github.com/pdmullen)) +- Reduce overly greedy NGHOST requirement for PPM+MHD [\#346](https://github.com/PrincetonUniversity/athena/pull/346) ([felker](https://github.com/felker)) +- Bug fix of OA for MHD [\#345](https://github.com/PrincetonUniversity/athena/pull/345) ([tomo-ono](https://github.com/tomo-ono)) + +**Closed issues:** + +- Access ParameterInput instance from user boundary conditions [\#563](https://github.com/PrincetonUniversity/athena/issues/563) +- Remove extraneous DeleteAthenaArray\(\) calls [\#559](https://github.com/PrincetonUniversity/athena/issues/559) +- Inconsistency in documentation of user-defined source terms? [\#556](https://github.com/PrincetonUniversity/athena/issues/556) +- Resurrect Princeton Jenkins server [\#515](https://github.com/PrincetonUniversity/athena/issues/515) +- `athena_read.py` produces corrugated spherical-polar `x2v` coordinates due to float precision at high resolution [\#498](https://github.com/PrincetonUniversity/athena/issues/498) +- FileNotFoundError for regression tests when "python" is not in PATH but "python3" is [\#479](https://github.com/PrincetonUniversity/athena/issues/479) +- Command-line output\#/dt and output\#/next\_time are handled incorrectly [\#451](https://github.com/PrincetonUniversity/athena/issues/451) +- Method for gravity source terms should be documented [\#450](https://github.com/PrincetonUniversity/athena/issues/450) +- Restart with too few cores produces confusing error [\#449](https://github.com/PrincetonUniversity/athena/issues/449) +- pgen 'disk' behaving strangely on KNL with --eos adiabatic [\#435](https://github.com/PrincetonUniversity/athena/issues/435) +- Unable to restart a simulation [\#429](https://github.com/PrincetonUniversity/athena/issues/429) +- HDF5 writer: Segfault in memory access [\#416](https://github.com/PrincetonUniversity/athena/issues/416) +- Incorrect running index for face-centered variable [\#403](https://github.com/PrincetonUniversity/athena/issues/403) +- Write generated configuration to file [\#396](https://github.com/PrincetonUniversity/athena/issues/396) +- Possiblly wrong code in EquationOfState::ApplyPrimitiveFloors [\#395](https://github.com/PrincetonUniversity/athena/issues/395) +- linwave: initial conditions do not scale with resolution [\#392](https://github.com/PrincetonUniversity/athena/issues/392) +- linwave1d with iso\_sound\_speed != 1 [\#391](https://github.com/PrincetonUniversity/athena/issues/391) +- Passive scalars behaving incorrectly upon refinement/de-refinement [\#390](https://github.com/PrincetonUniversity/athena/issues/390) +- Output synchronization: Unable to generate same number of output files for two simulations [\#387](https://github.com/PrincetonUniversity/athena/issues/387) +- Viscous diffusion in rotating frame [\#373](https://github.com/PrincetonUniversity/athena/issues/373) +- Unwanted spiral density waves in parallel sims [\#370](https://github.com/PrincetonUniversity/athena/issues/370) +- Potentially Ill-Defined Ambipolar Diffusion Constant Diffusivity [\#369](https://github.com/PrincetonUniversity/athena/issues/369) +- Unsafe SIMD loop\(s?\) in WeightedAve [\#349](https://github.com/PrincetonUniversity/athena/issues/349) +- Is the restriction of NGHOST for MHD with the 3rd order reconstruction scheme necessary? [\#339](https://github.com/PrincetonUniversity/athena/issues/339) +- Output next time is ignored on startup [\#310](https://github.com/PrincetonUniversity/athena/issues/310) +- Passive scalar issue with AMR [\#365](https://github.com/PrincetonUniversity/athena/issues/365) + +**Merged pull requests:** + +- Fully-implicit cosmic-ray diffusion module using Multigrid [\#550](https://github.com/PrincetonUniversity/athena/pull/550) ([tomidakn](https://github.com/tomidakn)) +- Replace std::fabs with std::abs [\#523](https://github.com/PrincetonUniversity/athena/pull/523) ([felker](https://github.com/felker)) +- Trigger PR test on new Jenkins server and fix all violations [\#518](https://github.com/PrincetonUniversity/athena/pull/518) ([changgoo](https://github.com/changgoo)) +- Add chemistry module built on passive scalars module [\#496](https://github.com/PrincetonUniversity/athena/pull/496) ([munan](https://github.com/munan)) +- Add non-relativistic radiation transport solvers \(explicit and implicit\) and cosmic ray transport [\#492](https://github.com/PrincetonUniversity/athena/pull/492) ([felker](https://github.com/felker)) +- Chemistry update [\#491](https://github.com/PrincetonUniversity/athena/pull/491) ([doraemonho](https://github.com/doraemonho)) +- Multigrid Gravity Solver Release Candidate [\#484](https://github.com/PrincetonUniversity/athena/pull/484) ([tomidakn](https://github.com/tomidakn)) +- Do not hardcode "python" executable name [\#480](https://github.com/PrincetonUniversity/athena/pull/480) ([felker](https://github.com/felker)) +- Rename source term functions [\#437](https://github.com/PrincetonUniversity/athena/pull/437) ([tomo-ono](https://github.com/tomo-ono)) +- Added "dcycle" option to output data at constant cycle intervals [\#417](https://github.com/PrincetonUniversity/athena/pull/417) ([tomidakn](https://github.com/tomidakn)) +- Support cherrypicking scalars [\#414](https://github.com/PrincetonUniversity/athena/pull/414) ([kahoooo](https://github.com/kahoooo)) +- Allow cherrypicking variables to be output [\#413](https://github.com/PrincetonUniversity/athena/pull/413) ([kahoooo](https://github.com/kahoooo)) +- Low-dissipation HLLC/HLLD solvers \(Minoshima et al. 2021\) [\#380](https://github.com/PrincetonUniversity/athena/pull/380) ([tomidakn](https://github.com/tomidakn)) ## [v21.0](https://github.com/PrincetonUniversity/athena/tree/v21.0) (2021-01-06) From ec5ff3ca08616c51421e00777ab52c8b4c4f619a Mon Sep 17 00:00:00 2001 From: Kyle Gerard Felker Date: Fri, 14 Jun 2024 13:00:24 -0500 Subject: [PATCH 3/4] Update release date --- src/main.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main.cpp b/src/main.cpp index 842e32bb2..897de78c0 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -63,7 +63,7 @@ //! \brief Athena++ main program int main(int argc, char *argv[]) { - std::string athena_version = "version 24.0 - April 2024"; + std::string athena_version = "version 24.0 - June 2024"; char *input_filename = nullptr, *restart_filename = nullptr; char *prundir = nullptr; int res_flag = 0; // set to 1 if -r argument is on cmdline From 037f4d8ce0fdf12ad686aeba94288a0318b1aa6e Mon Sep 17 00:00:00 2001 From: Kyle Gerard Felker Date: Fri, 14 Jun 2024 13:22:15 -0500 Subject: [PATCH 4/4] Add merged PRs and closed Issues since 2024-04-02 --- CHANGELOG.md | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2c0f4b5a1..3482c9bd5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -24,6 +24,9 @@ The automatically-generated content should be used for reference when writing th **Implemented enhancements:** +- Fixes athena\_read's unnecessarily large memory allocation [\#587](https://github.com/PrincetonUniversity/athena/pull/587) ([dgagnier](https://github.com/dgagnier)) +- Divergence-preserving prolongation of coarse/fine shared face-centered fields for 3D spherical polar and cylindrical grids [\#584](https://github.com/PrincetonUniversity/athena/pull/584) ([mariareneemf](https://github.com/mariareneemf)) +- Divergence-preserving prolongation of coarse/fine shared face-centered fields for 3D spherical polar grids [\#582](https://github.com/PrincetonUniversity/athena/pull/582) ([mariareneemf](https://github.com/mariareneemf)) - Remove unused DEBUG macro [\#531](https://github.com/PrincetonUniversity/athena/issues/531) - Make DEBUG macro a binary 1/0 instead of string [\#533](https://github.com/PrincetonUniversity/athena/pull/533) ([felker](https://github.com/felker)) - Update cpplint.py [\#524](https://github.com/PrincetonUniversity/athena/pull/524) ([felker](https://github.com/felker)) @@ -53,6 +56,8 @@ The automatically-generated content should be used for reference when writing th - 4th order reconstruction and outflow BCs bug [\#298](https://github.com/PrincetonUniversity/athena/issues/298) - Add more runtime NGHOST checks \(especially for SMR/AMR\) [\#163](https://github.com/PrincetonUniversity/athena/issues/163) - GR-AMR incompatibility [\#64](https://github.com/PrincetonUniversity/athena/issues/64) +- Remove division-by-zero bug for viscosity + 3d polar boundary condition [\#581](https://github.com/PrincetonUniversity/athena/pull/581) ([apbailey](https://github.com/apbailey)) +- Replace more nonconstant references with const [\#577](https://github.com/PrincetonUniversity/athena/pull/577) ([felker](https://github.com/felker)) - Fix x1v for Curvilinear+PPM [\#566](https://github.com/PrincetonUniversity/athena/pull/566) ([forrestglines](https://github.com/forrestglines)) - Remove all possibly extraneous DeleteAthenaArray calls [\#560](https://github.com/PrincetonUniversity/athena/pull/560) ([felker](https://github.com/felker)) - Fixed Typo in Error Messages [\#557](https://github.com/PrincetonUniversity/athena/pull/557) ([Rgokemeijer](https://github.com/Rgokemeijer)) @@ -93,6 +98,8 @@ The automatically-generated content should be used for reference when writing th **Closed issues:** +- athena\_read allocates unnecessarily large amount of memory [\#586](https://github.com/PrincetonUniversity/athena/issues/586) +- Array indexing errors in llf\_mhd\_rel\_no\_transform.cpp [\#568](https://github.com/PrincetonUniversity/athena/issues/568) - Access ParameterInput instance from user boundary conditions [\#563](https://github.com/PrincetonUniversity/athena/issues/563) - Remove extraneous DeleteAthenaArray\(\) calls [\#559](https://github.com/PrincetonUniversity/athena/issues/559) - Inconsistency in documentation of user-defined source terms? [\#556](https://github.com/PrincetonUniversity/athena/issues/556) @@ -122,6 +129,8 @@ The automatically-generated content should be used for reference when writing th **Merged pull requests:** +- Remove Travis CI YAML and badge from README [\#592](https://github.com/PrincetonUniversity/athena/pull/592) ([felker](https://github.com/felker)) +- Add better exclusion for MHD+shearing box+SMR with refinement in x3 dir at shearing boundary [\#591](https://github.com/PrincetonUniversity/athena/pull/591) ([felker](https://github.com/felker)) - Fully-implicit cosmic-ray diffusion module using Multigrid [\#550](https://github.com/PrincetonUniversity/athena/pull/550) ([tomidakn](https://github.com/tomidakn)) - Replace std::fabs with std::abs [\#523](https://github.com/PrincetonUniversity/athena/pull/523) ([felker](https://github.com/felker)) - Trigger PR test on new Jenkins server and fix all violations [\#518](https://github.com/PrincetonUniversity/athena/pull/518) ([changgoo](https://github.com/changgoo))