Bedrock stack network id protocol fix for 1.16.220 to 1.20.10

[irkmandeer]

The stack_id field in StackRequestSlotInfo and Item needs to be varint and not zigzag32.

This causes a mismatch of the stack_id for an item stack between the inventory_content, inventory_slot, inventory_transaction, item_stack_request and item_stack_response packets.

The problem can be seen by using the relay to print the inventory_content, item_stack_request and item_stack_response packets; moving an item in the inventory, then comparing the stack_id from the packets

Code references

• CloudburstMC
• PMMP

The change was applied and tested for for all supported (and playable 1.16.220+) versions against vanilla bedrock servers.

[extremeheat]

Actually, I am confused here. Both your links do not show an unsigned varint, they show a signed varint, which is what the current field is. How are you sure this field is not wrong as opposed to the others?

[irkmandeer]

You are absolutely correct!

I specifically checked the other implementations since both types work, just as long as they are consistent. I've got no idea why my brain decided on varint when it's clearly zigzag and network ids always seem to be zigzag.

I wrote tests for all this, so let me change it to zigzag, and run everything again.

Do I need to close this PR and open another one?

[extremeheat]

Do I need to close this PR and open another one?

Up to you

[irkmandeer]

Sorry for the wait, I was out of action the last couple of weeks.

I just created a new PR 762 for this.