Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elytra support
This adds support for elytra, but I needed to know if elytra flying was supported and was rocket flying supported and what index the rocket entity attachement was and what type of data was it
versions
elytra support
1.9.4: 0 0x80 bit
firework support
1.11.2: 7 VarInt
firework entity reports its attached entity
1.14.4: 7 VarInt -> 8 VarInt
Note: This seems to have been a temporary mistaken change. 1.14 is 8 OptVarInt
fireworks entity attached changed index
https://wiki.vg/index.php?title=Entity_metadata&direction=next&oldid=14800
https://wiki.vg/index.php?title=Entity_metadata&direction=next&oldid=15236
1.15.2: 8 VarInt -> 8 OptVarInt
attached entity: VarInt to OptVarInt
1.17.1: 8 OptVarInt -> 9 OptVarInt
https://wiki.vg/index.php?title=Entity_metadata&oldid=16738
latest
firework naming
from entities.json
note: 1.13 uses firework_rocket for rocket flying