Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elytra support #761

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Elytra support #761

merged 2 commits into from
Aug 25, 2023

Conversation

lkwilson
Copy link
Contributor

@lkwilson lkwilson commented Aug 24, 2023

elytra support

This adds support for elytra, but I needed to know if elytra flying was supported and was rocket flying supported and what index the rocket entity attachement was and what type of data was it

versions

elytra support

1.9.4: 0 0x80 bit

firework support

1.11.2: 7 VarInt

firework entity reports its attached entity

1.14.4: 7 VarInt -> 8 VarInt

Note: This seems to have been a temporary mistaken change. 1.14 is 8 OptVarInt

fireworks entity attached changed index

1.15.2: 8 VarInt -> 8 OptVarInt

attached entity: VarInt to OptVarInt

1.17.1: 8 OptVarInt -> 9 OptVarInt

firework naming

from entities.json

  • 1.11: fireworks_rocket (mob/obj)
  • 1.13: fireworks_rocket (mob) / firework_rocket (obj)
  • 1.14: firework_rocket (mob)
  • 1.17: firework_rocket (projectile)

note: 1.13 uses firework_rocket for rocket flying

@rom1504 rom1504 merged commit 72a2677 into PrismarineJS:master Aug 25, 2023
5 checks passed
@rom1504
Copy link
Member

rom1504 commented Aug 25, 2023

/makerelease

@rom1504bot rom1504bot mentioned this pull request Aug 25, 2023
@lkwilson lkwilson deleted the elytra-support branch August 26, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants