Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HTML Structure and Accessibility for #finance.html file. #575

Closed
anshumangahlot opened this issue Oct 17, 2024 · 2 comments
Closed

Comments

@anshumangahlot
Copy link
Contributor

anshumangahlot commented Oct 17, 2024

Description:

The current HTML code for the Finance Courses page has several issues that could be improved for better accessibility, readability, and overall quality. Below are the identified problems and suggestions for enhancement:

Issues Identified:

  1. Meta Description: The meta description mentions "Modern Physics," which is not relevant to the finance content. This should be revised to accurately reflect the topic.

  2. Image Alt Text: The alt attributes for images need to be more descriptive to improve accessibility. For example, "Financial securities image" should be more specific.

  3. Image Dimensions: The height of the images is set to 100 pixels, which may distort the aspect ratio. A larger height (e.g., 200 pixels) is recommended.

  4. Redundant Class Names: Class names like title-lg and title-sm could be more descriptive. Consider using names that indicate their purpose, such as course-title and course-duration.

  5. Link Accessibility: The links to course pages should have clearer and more descriptive text to enhance accessibility.

  6. Section Heading Structure: Ensure the hierarchy of headings (h2, h3) is consistent and meaningful.

  7. Use of Semantic HTML: Using more semantic elements, like <article> for course cards, would improve the structure and readability of the code.

  8. Responsive Design: Confirm that the linked CSS addresses responsiveness, especially for mobile devices.

  9. Favicon Link: Verify that the favicon file exists at the specified path and consider adding a fallback for browsers that do not support SVG.

Additional Notes:

Copy link

Thanks for creating the issue in SkillWise!
Before you start working on your PR, please make sure to:

  • ⭐ Star the repository if you haven't already.
  • Pull the latest changes to avoid any merge conflicts.
  • Attach before & after screenshots in your PR for clarity.
  • Include the issue number in your PR description for better tracking.
    Don't forget to follow @PriyaGhosal – Project Maintainer – & @anuragverma108 – Project Collaborator – for more updates!

We're excited to see your contribution as part of Hacktoberfest 2024! 🎉
Happy open-source contributing!

Copy link

Thank you for creating this issue! 🎉 Your issue will soon be reviewed by Project Maintainers. In the meantime, please make sure to provide all the necessary details and context. If you have any questions or additional information, feel free to add them here. Your contributions are highly appreciated! 😊

You can also check our CONTRIBUTING.md for guidelines on contributing to this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants