Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Call to action] UT coverage improvement task #569

Open
wawa0210 opened this issue Oct 24, 2024 · 0 comments
Open

[Call to action] UT coverage improvement task #569

wawa0210 opened this issue Oct 24, 2024 · 0 comments
Labels
good first issue Good for newcomers
Milestone

Comments

@wawa0210
Copy link
Member

wawa0210 commented Oct 24, 2024

Task description:

Currently, the overall test coverage of the HAMi project is 26.9%, which is far from enough. Interested partners are urgently needed to contribute to improve the ut coverage.

go file ut coverage
pkg/scheduler/scheduler.go 28.30%
pkg/util/util.go 29.45%
pkg/device/cambricon/device.go 13.43%
pkg/device/ascend/device.go 2.92%
pkg/device/nvidia/device.go 31.58%
pkg/monitor/nvidia/cudevshr.go 0.00%
pkg/device/mthreads/device.go 14.47%
pkg/device/hygon/device.go 15.17%
pkg/util/nodelock/nodelock.go 0.00%
pkg/device/iluvatar/device.go 29.85%
pkg/scheduler/routes/route.go 0.00%
pkg/monitor/nvidia/v1/spec.go 0.00%
pkg/monitor/nvidia/v0/spec.go 0.00%
pkg/device/devices.go 27.14%
pkg/scheduler/score.go 67.05%
pkg/oci/spec.go 0.00%
pkg/oci/spec_mock.go 0.00%
pkg/scheduler/webhook.go 46.81%
pkg/scheduler/event.go 44.83%
pkg/k8sutil/client.go 0.00%
pkg/scheduler/nodes.go 67.86%
pkg/device/ascend/vnpu.go 0.00%
pkg/util/client/client.go 54.17%
pkg/scheduler/pods.go 88.89%
pkg/version/version.go 0.00%
pkg/scheduler/policy/gpu_policy.go 83.87%
pkg/k8sutil/pod.go 76.47%
pkg/scheduler/policy/constant.go 100.00%
pkg/scheduler/policy/node_policy.go 100.00%
pkg/oci/runtime_exec.go 100.00%
pkg/oci/runtime_mock.go 100.00%

image

Solution:

Who can join or take the task:

The good first issue is intended for first-time contributors to get started on his/her contributor journey.

After a contributor has successfully completed 1-2 good first issue's,
they should be ready to move on to help wanted items, saving the remaining good first issue for other new contributors.

How to join or take the task:

Anyone who wants to participate in this task can make a note in the comments(avoid duplicate claims), such as

/assign I want to claim pkg/scheduler/event.go

Just reply on the issue with the message /assign in a separate line.

Then, the issue will be assigned to you.

How to ask for help:

If you need help or have questions, please feel free to ask on this issue.
The issue author or other members of the community will guide you through the contribution process.

@wawa0210 wawa0210 added the good first issue Good for newcomers label Oct 24, 2024
@wawa0210 wawa0210 added this to the v2.5 milestone Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant