Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create LayerFactory and ComponentStore from common class #7145

Closed
marksgraham opened this issue Oct 19, 2023 · 0 comments
Closed

Create LayerFactory and ComponentStore from common class #7145

marksgraham opened this issue Oct 19, 2023 · 0 comments

Comments

@marksgraham
Copy link
Contributor

Is your feature request related to a problem? Please describe.
There are similarities between the LayerFactory and newly implemented ComponentStore (see this PR) - both are factories, one for objects, one for functions.

Describe the solution you'd like
We've decided to create a common Factory class these two inherit from.

Describe alternatives you've considered
It is also possible to use LayerFactory for both cases, but would require giving it a more generic name and this would mean we would have to deprecate LayerFactory.

Additional context
Add any other context or screenshots about the feature request here.

@wyli wyli closed this as completed in ccd32ca Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant