Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support authorizeOrder pre-execution call in reference #5

Merged
merged 1 commit into from
Feb 3, 2024
Merged

support authorizeOrder pre-execution call in reference #5

merged 1 commit into from
Feb 3, 2024

Conversation

0age
Copy link
Contributor

@0age 0age commented Feb 3, 2024

Motivation

Solution

@0age
Copy link
Contributor Author

0age commented Feb 3, 2024

small TODO — if we want to support restricted orders via basic fulfillment, the order status should be updated after the authorizeOrder call (right now it's being updated before) so as to be consistent with the standard fulfillment methods and so the zone can access the pre-auth status if needed.

@0age 0age mentioned this pull request Feb 3, 2024
Closed
@ryanio ryanio force-pushed the reference-authorize-order-call branch from 704d1af to 5e0cc23 Compare February 3, 2024 01:28
@0age 0age merged commit 8f3e1cd into main Feb 3, 2024
6 checks passed
@0age 0age deleted the reference-authorize-order-call branch February 3, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@0age