Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AssistantAgent should have a more general way to trigger a StopMessage response. #4020

Closed
afourney opened this issue Oct 31, 2024 · 6 comments · Fixed by #4030 · May be fixed by Promptless/autogen-test#1
Closed

AssistantAgent should have a more general way to trigger a StopMessage response. #4020

afourney opened this issue Oct 31, 2024 · 6 comments · Fixed by #4030 · May be fixed by Promptless/autogen-test#1
Assignees
@ekzhu @victordibia @afourney @gagb
Labels
proj-agentchat
Milestone
0.4.0

Comments

@afourney
Copy link
Member

afourney commented Oct 31, 2024 •
edited
Loading

Patterned off of the v0.2 AssistantAgent, some agents include very specific termination logic which might go against the Team or Orchestrator logic. E.g.,

autogen/python/packages/autogen-magentic-one/src/autogen_magentic_one/agents/coder.py

Line 35 in 4023454

Reply "TERMINATE" in the end when everything is done.""")

We should standardize where termination logic lives.
@ekzhu ekzhu added this to the 0.4.0 milestone Oct 31, 2024
@ekzhu
Copy link
Collaborator

ekzhu commented Oct 31, 2024

To be clear, the assistant agent uses the string to respond with a StopMessage, however it is still the team or the task's decision to perform termination.

@victordibia
Copy link
Collaborator

Yeah .. some notes here ..

The AssistantAgent default prompt encourages it to respond with Terminate when the task is done hence the check for terminate and issuing a stop message.

The system message and terminate logic are related here. For example assuming the user supplies their own system message, the termination logic has less of an effect.

@ekzhu
Copy link
Collaborator

ekzhu commented Oct 31, 2024

Yes, we can think of a more general way to trigger a StopMessage

@ekzhu ekzhu changed the title Some agents include termination logic. This is moving to the team/orchestrator. AssistantAgent should have a more general way to trigger a StopMessage response. Oct 31, 2024
@afourney
Copy link
Member Author

Yes, we can think of a more general way to trigger a StopMessage

Or maybe don't send it at all. Let the Team decide.

@ekzhu
Copy link
Collaborator

ekzhu commented Nov 1, 2024

AssistantAgent no longer sends out StopMessage. We can use TextMentionTermination("TERMINATE") on the team instead.

@ekzhu ekzhu mentioned this issue Nov 1, 2024
Merged
@victordibia
Copy link
Collaborator

victordibia commented Nov 1, 2024 •
edited
Loading

Seems to be resolved in #4042 .
Happy to close at some point

@frances720 frances720 mentioned this issue Nov 4, 2024
Open
@promptless promptless bot mentioned this issue Nov 5, 2024
Open
@promptless promptless bot mentioned this issue Nov 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ekzhu ekzhu

@victordibia victordibia

@afourney afourney

@gagb gagb

Labels
proj-agentchat
Projects
None yet
Milestone
0.4.0
4 participants
@ekzhu @victordibia @afourney @gagb