Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure line-heights use unitless measurements in all CSS files. #224

Open
zoltan-dulac opened this issue Oct 9, 2024 · 1 comment
Open

Comments

@zoltan-dulac
Copy link
Collaborator

If you look in bin/enforceRemFontSize.sh, you will see how we check to ensure there are no font-sizes using pixels in the CSS files (they should be all rems or any other relative unit). We need a similar check to ensure line-heights use unitless measurements.

Read this section of the Resizable Typography page for more information.

@psastha-patel
Copy link
Contributor

This issue is almost resolve just need few changes. Currently it checking less file but we need to check through the css file. Edit this one small change and done!! PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants