Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't make it work with german client #94

Open
dasgigi opened this issue Mar 6, 2023 · 5 comments
Open

Can't make it work with german client #94

dasgigi opened this issue Mar 6, 2023 · 5 comments

Comments

@dasgigi
Copy link

dasgigi commented Mar 6, 2023

So, I play with german language, but cant make this addon work.

German text would be: /Diesen Fang als Sammlerstück einholen? Sammlerwert: .*/

Did I miss something ?

fish1

@daemitus
Copy link
Collaborator

daemitus commented Mar 6, 2023 via email

@tmschorr
Copy link

I have tested it, if I use the shorter variant of the text, e.g. 'Diesen Fang als', then it works. But it would be nicer if the corresponding UNICODE is loaded in the program, so that not everyone who uses the German client is dependent on finding out this trick first.

@dasgigi
Copy link
Author

dasgigi commented Mar 12, 2023

I have tested it, if I use the shorter variant of the text, e.g. 'Diesen Fang als', then it works. But it would be nicer if the corresponding UNICODE is loaded in the program, so that not everyone who uses the German client is dependent on finding out this trick first.

Thanks dude, this workaround works like a charm :)

@baelrayneVessdren
Copy link

Little late to the party but if someone else sees this, try this for a more generic string. It will let you have differing collectors values:
/Diesen Fang als Sammlerstück einholen? Sammlerwert: [0-9]{1,}/

Also: if the addon uses generic regex, the "?" at the end of the first sentence is the issue. The "?" is an expression in Regex so without the "" in front of it, it will be treated as a command and not the actual symbol.

@Mara-Li
Copy link

Mara-Li commented Aug 13, 2024

I think the french translation have the same problem, character
So the regex for french: Obtenir cet objet en tant que .collectionnable..* I use with success!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants