Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add French name in /Items.json #7

Open
3 of 4 tasks
Purukitto opened this issue Sep 27, 2020 · 6 comments
Open
3 of 4 tasks

Add French name in /Items.json #7

Purukitto opened this issue Sep 27, 2020 · 6 comments
Labels
⚠️ API Update This will need corresponding changes in the API and would break the same if not updated enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Purukitto
Copy link
Owner

Purukitto commented Sep 27, 2020

Description

Add jname (Japanese name), cname (Chinese name (simplified)) and fname(Frech name) to items.json to make it consistent with the rest of the database.

The required structure:

From:

{
    "id": 1,
    "ename": "Master Ball",
    "type": "Pokeballs",
    "description": "The best Ball with the ultimate level of performance. It will catch any wild Pokémon without fail."
}

To:

{
    "id": 1,
    "name": {
        "english": "Master Ball",
        "japanese": "マスターボール",
        "chinese": "大师球",
        "french": "Master Ball"
    }
    "type": "Pokeballs",
    "description": "The best Ball with the ultimate level of performance. It will catch any wild Pokémon without fail."
}

Tasks :

- [ ] To add jname, cname and fname

  • Change name structure
  • To add jname
  • To add cname
  • To add fname

Please mention this issue in your PR (#7) and add the above to-do in the PR as well

Comment below if you would like to claim this issue, please do not start working on the issue unless assigned to you explicitly

Repository owner deleted a comment from issue-label-bot bot Sep 27, 2020
@Karim-Adnan
Copy link
Contributor

I would like to contribute!

@Purukitto
Copy link
Owner Author

I would like to contribute!

Sure go ahead

@Purukitto Purukitto assigned Purukitto and Karim-Adnan and unassigned Purukitto Sep 27, 2020
@Purukitto Purukitto added 🚧 WIP Still work-in-progress, please don't review and don't merge and removed hacktoberfest feature_request good first issue Good for newcomers labels Sep 27, 2020
@Purukitto Purukitto added this to the Uniform structure milestone Sep 28, 2020
@Purukitto Purukitto added the ⚠️ API Update This will need corresponding changes in the API and would break the same if not updated label Sep 29, 2020
@Purukitto
Copy link
Owner Author

@Karim-Adnan Please refer to the updated structure

@Karim-Adnan
Copy link
Contributor

alright

@Purukitto
Copy link
Owner Author

cname and jname already added, only french name left

@Purukitto Purukitto changed the title Add jname , cname and fname in /Items.json Add French name in /Items.json Oct 24, 2020
@Purukitto Purukitto added enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed and removed 🚧 WIP Still work-in-progress, please don't review and don't merge labels Oct 24, 2020
@mintymelinda
Copy link

I can do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ API Update This will need corresponding changes in the API and would break the same if not updated enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants