-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add French name in /Items.json #7
Labels
⚠️ API Update
This will need corresponding changes in the API and would break the same if not updated
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
Milestone
Comments
I would like to contribute! |
Sure go ahead |
@Karim-Adnan Please refer to the updated structure |
alright |
cname and jname already added, only french name left |
I can do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
⚠️ API Update
This will need corresponding changes in the API and would break the same if not updated
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
Description
Add jname (Japanese name), cname (Chinese name (simplified)) and fname(Frech name) to items.json to make it consistent with the rest of the database.
The required structure:
From:
To:
Tasks :
- [ ] To addjname
,cname
andfname
name
structurejname
cname
fname
Please mention this issue in your PR (
#7
) and add the above to-do in the PR as wellComment below if you would like to claim this issue, please do not start working on the issue unless assigned to you explicitly
The text was updated successfully, but these errors were encountered: