Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganizar scraper y utilities #250

Open
2 of 5 tasks
fzuccolo opened this issue Jun 11, 2020 · 1 comment
Open
2 of 5 tasks

Reorganizar scraper y utilities #250

fzuccolo opened this issue Jun 11, 2020 · 1 comment

Comments

@fzuccolo
Copy link
Member

fzuccolo commented Jun 11, 2020

Scraping

Podríamos agrupar todo lo relacionado a la descarga de páginas y listas en el directorio src/scraping (con una sola p).

  • Mover utils/scraper.py y utils/workerpool.py a scraping/.
  • Extraer info relevante de utils/como_hacer_un_dump.txt y agregarla a scraping/readme.md
  • Mover src/list_articles_by_namespaces.py a src/scraper/
  • Mover la función get_lists de cdpetron a src/list_articles.py

Me parece que quedaría más lógico y fácil de extender, independiéntemente de la futura reimplementación del scraper:

src/
`-- scraping/
    |-- __init__.py
    |-- list_articles.py
    |-- list_articles_by_namespaces.py
    |-- portals.py
    |-- scraper.py
    `-- readme.md

Utilities

  • Mover src/xml_vs_html/ a utilities/xml_vs_html/

En src/utilities quedarían sólo scripts que no son usados por cdpedia o cdpetron. Habría que revisarlos para determinar si aún son relevantes:

utilities/
|-- xml_vs_html/
|-- benchmarkIndice.py
|-- buscarEnBloque.py
|-- descargaImagenes.py
|-- distrib_image.py
|-- makeLista.py
|-- parseaImagenes.py
|-- pick_samples.sh
|-- verComprimido.py
|-- verIndice.py
`-- xpm2pickle.py
@facundobatista
Copy link
Member

+1, con el detalle que utils/workerpool.py desaparece, y estaría bueno esperar a que scraper.py se use como lib, no como "script".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants