Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add help text and fix URL validation to prepend https:// if missing #590

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add help text and fix URL validation to prepend https:// if missing #590

wants to merge 2 commits into from

Conversation

JigyasuRajput
Copy link
Contributor

Cambios propuestos:

  • Added help text to the URL input form to guide users.
  • Fixed validation to automatically prepend https:// to URLs if missing

Temas tratados:

Pruebas realizadas:

  • Built and ran the application inside a Docker container without errors.
  • Tested the URL input form with valid and invalid URLs (with and without https://).
  • Verified the expected behavior in the Dockerized environment.

Cómo probar los cambios:

  1. Navigate to the form with the URL input field.
  2. Enter a URL without https:// (e.g., www.github.com) and save.
  3. Verify that https:// is automatically added to the URL and saved correctly

Gracias por contribuir con el proyecto.

Estamos pendiente de revisar los cambios propuestos.

facundobatista
facundobatista approved these changes Dec 24, 2024
View reviewed changes
Copy link
Member

@facundobatista facundobatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@facundobatista facundobatista enabled auto-merge (squash) December 24, 2024 20:49
@facundobatista
Copy link
Member

Hello! It looks a test is faling?

facundobatista
facundobatista requested changes Dec 24, 2024
View reviewed changes
Copy link
Member

@facundobatista facundobatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facundobatista facundobatista facundobatista requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pantalla creacion de empresa campo url poco específico
2 participants
@JigyasuRajput @facundobatista