-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 403 Error Page Aesthetics #592
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks there are changes here that are also in other proposed PR?
Also please double check changes, there are some that are not really changing anything useful, thanks!
joboffers/tests/test_models.py
Outdated
joboffer_url = reverse('joboffers:view', kwargs={'slug': dummy_job_slug}) | ||
expected_url = "".join(('https://example.com', joboffer_url)) | ||
|
||
joboffer = JobOffer(slug=dummy_job_slug) | ||
result = joboffer.get_full_url() | ||
assert expected_url == result | ||
|
||
assert result == expected_url |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these changes does not add any value...
Cambios propuestos:
Temas tratados:
Pruebas realizadas:
Cómo probar los cambios:
Gracias por contribuir con el proyecto.
Estamos pendiente de revisar los cambios propuestos.