You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
# when DuelEvent is interception, we need to overwrite this and the previous DuelEvent
events=events[:-1]
event=interception_event
I guess the reasoning is that a defensive duel is always paired with an offensive duel and this would delete the offensive duel. However, it seems that the "interception" tag (1401) can also be given to the offensive duel. In that case, the wrong event will be deleted. For example, in the sequence of events below, the current implementation would delete the pass event.
So, I think we should update the logic here to make sure the correct event gets deleted. Furthermore, I wonder whether it wouldn't be better to convert an Offensive Duel + interception to a Ball receipt (under pressure).
The text was updated successfully, but these errors were encountered:
When a duel is also an interception, the Wyscout v2 deserializer deletes the last event before the interception.
kloppy/kloppy/infra/serializers/event/wyscout/deserializer_v2.py
Lines 626 to 629 in 0de2285
I guess the reasoning is that a defensive duel is always paired with an offensive duel and this would delete the offensive duel. However, it seems that the "interception" tag (1401) can also be given to the offensive duel. In that case, the wrong event will be deleted. For example, in the sequence of events below, the current implementation would delete the pass event.
You can see the corresponding video here: https://youtu.be/GrkiZjoyugA?t=4813. It's the ball touch by Alderweireld.
So, I think we should update the logic here to make sure the correct event gets deleted. Furthermore, I wonder whether it wouldn't be better to convert an Offensive Duel + interception to a Ball receipt (under pressure).
The text was updated successfully, but these errors were encountered: