Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wyscout v2] Implement desirialization of take ons #269

Open
probberechts opened this issue Dec 27, 2023 · 0 comments
Open

[Wyscout v2] Implement desirialization of take ons #269

probberechts opened this issue Dec 27, 2023 · 0 comments

Comments

@probberechts
Copy link
Contributor

Ground attacking duel with tags "Take on left" (503) or "Take on right" (504) should be converted to a TakeOnEvent.

In socceraction, we also convert simulations (subevent 25) to failed take-ons, but I can see that this is debatable. Implementing this would require:

  • Simulations not preceded by a failed take-on must be converted to a failed take-on
  • Simulation events which are preceded by a failed take-on should be removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@probberechts