Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deserialization of certificates #310

Conversation

nielstron
Copy link
Contributor

@nielstron nielstron commented Feb 17, 2024

This fixes deserializing transactions that contain a list of certificates (or more specifically, fixes certificate deserialization from cbor)

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (b2d74cc) 83.11% compared to head (6171067) 82.88%.
Report is 1 commits behind head on main.

Files Patch % Lines
pycardano/certificate.py 56.75% 9 Missing and 7 partials ⚠️
pycardano/txbuilder.py 33.33% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
- Coverage   83.11%   82.88%   -0.24%     
==========================================
  Files          28       28              
  Lines        3441     3476      +35     
  Branches      844      865      +21     
==========================================
+ Hits         2860     2881      +21     
- Misses        430      438       +8     
- Partials      151      157       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nielstron nielstron force-pushed the feat/fix_deserialization_of_certificates branch 2 times, most recently from bcaa6f1 to 6171067 Compare February 20, 2024 16:13
@nielstron nielstron force-pushed the feat/fix_deserialization_of_certificates branch from 6171067 to b6b48ac Compare February 20, 2024 20:45
@nielstron
Copy link
Contributor Author

I think this has been scooped by #321

@nielstron nielstron closed this Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants