-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow modification via unlocking measurement report when set to readonly #125
Comments
@fedorov Did I forget something? Feel free to add bullet points |
We might need to handle it differently based on the completion status, where continuing a just "saved" report can be continued and a "completed" cannot. |
…CR#125): - a copy of table node and segmentation node will be created and referenced - appending _copy to segmentation and table node names
I am not sure it makes sense to create a copy of the measurements table, since we may not be able to recompute the original measurements. I think to me it would be more intuitive if on report modification the table is reset, user is allowed to modify segmentation, which would then be saved into a new DICOM object, and measurements table is recomputed. |
@fedorov Shall we close this issue or do we want to provide this functionality? |
I think it would be good to provide this functionality, but it is not a high priority. |
@fedorov I don't know if this feature is required. It was implemented in che85@d88717f but never merged into master |
Yes, I am not sure there was a PR. Let's not worry about it for now - let's resolve bugs and features that are needed for @chribaue use cases, and switch to PI-RADS. |
Ok great. I just wanted to go through all issues and close those ones that have been resolved. |
Users should be allowed to unlock a readonly measurement report. Of the following things need to be taken care:
The text was updated successfully, but these errors were encountered: