Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Submission]: qiskit-classroom #523

Closed
minwook-shin opened this issue Sep 6, 2023 · 10 comments · Fixed by #524
Closed

[Submission]: qiskit-classroom #523

minwook-shin opened this issue Sep 6, 2023 · 10 comments · Fixed by #524
Labels
ready submission Project submission

Comments

@minwook-shin
Copy link
Contributor

Github repo

https://github.com/KMU-quantum-classroom/qiskit-classroom

Description

Qiskit-classroom is a toolkit that helps implement quantum algorithms by converting and visualizing different expressions used in the Qiskit ecosystem using Qiskit-classroom-converter. The following three transformations are supported : Quantum Circuit to Dirac notation, Quantum Circuit to Matrix, Matrix to Quantum Circuit etc...

Email

No response

Alternatives

No response

License

Apache License 2.0

Affiliations

No response

Labels

Visualization

Website

https://github.com/KMU-quantum-classroom

@minwook-shin minwook-shin added the submission Project submission label Sep 6, 2023
@minwook-shin
Copy link
Contributor Author

This GUI Application maintainer : fmowl10
cc. @fmowl10

@github-actions github-actions bot added the on hold Waiting for action from third party label Sep 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Standard tests

❌ The submission didn't pass the standard check.
Please follow minimal requirements for project or/and add ecosystem.json configuration in the root of the project.
Read more here https://github.com/qiskit-community/ecosystem/blob/main/docs/project_overview.md#adding-project-to-the-ecosystem.

Stable tests

⚠️ The submission didn't pass the stable check.
This means your project doesn't work with the latest version of Qiskit.
This is purely informational and doesn't affect your project joining the Ecosystem, but you may want to investigate the problem.

Development tests

⚠️ The submission didn't pass the development check.
This means your project might not work with the next version of Qiskit.
This is purely informational and doesn't affect your project joining Ecosystem.


Logs: https://github.com/qiskit-community/ecosystem/actions/runs/6092118171
PR #524

@fmowl10
Copy link

fmowl10 commented Sep 6, 2023

can ecosystem.json configure dependencies in debian packages?

@mickahell
Copy link
Collaborator

mickahell commented Sep 6, 2023

Hi @fmowl10 :)

As you have an requirements-dev.txt you need an ecosystem.json with this minimal conf :

{
    "dependencies_files": [
        "requirements.txt",
        "requirements-dev.txt"
    ]
}

About the debian package, currently we don't have this option but indeed it could be a good feature. I'll create an issue and thing about that. I'll came with a response during the week or week-end.

@mickahell
Copy link
Collaborator

@fmowl10

I created you a PR for the ecosystem file : KMU-quantum-classroom/qiskit-classroom#6

I did a test with my PR to add debian package and that's working, well. It probably be merged this week or next week.

@fmowl10
Copy link

fmowl10 commented Sep 13, 2023

I checked and merged your (My project) PR.

frankharkins pushed a commit that referenced this issue Sep 19, 2023
<!--
⚠️ If you do not respect this template, your pull request will be
closed.
⚠️ Your pull request title should be short detailed and understandable
for all.
⚠️ Also, please add a release note file using reno if the change needs
to be
  documented in the release notes.
⚠️ If your pull request fixes an open issue, please link to the issue.

- [ ] I have added the tests to cover my changes.
- [ ] I have updated the documentation accordingly.
- [ ] I have read the CONTRIBUTING document.
-->

### Summary

Allow the possibility to add debian package.

### Details and comments

- [x] Update tox tpl
- [x] Update docs
- [x] Tests [dry
run](https://github.com/mickahell/ecosystem/actions/runs/6162831052/attempts/1#summary-16725102584)

---
Closes #526 
Related to #523
@mickahell mickahell reopened this Sep 19, 2023
@github-actions github-actions bot added ready and removed on hold Waiting for action from third party labels Sep 19, 2023
@github-actions
Copy link
Contributor

Standard tests

✨ Successfull submission!

Stable tests

✨ Tests with latest version of Qiskit release passed!

Development tests

✨ Tests with development version of Qiskit release passed!


Logs: https://github.com/qiskit-community/ecosystem/actions/runs/6235794002
PR #524

@mickahell
Copy link
Collaborator

@fmowl10 Your project passed :) the submission is now in PR review

frankharkins pushed a commit that referenced this issue Sep 20, 2023
Add qiskit-classroom to list.

---
Closes #523

Co-authored-by: mickahell <[email protected]>
@github-actions
Copy link
Contributor

hello @minwook-shin! You joined the Qiskit Ecosystem a little while ago and I just wanted to check in and let you know of some follow up actions you can take to make the most of joining the program, if you're interested:

💬 Join other Qiskit ecosystem developers in the Slack channel #qiskit-ecosystem (if you are not in the Qiskit workspace yet, you can sign up here: https://qisk.it/join-slack)

🧠 Help us define the future of the Qiskit Ecosystem: we recently started an RFC on how the Ecosystem should be structured. It is very draft-y at the moment, but you can subscribe for notifications here Qiskit/RFCs#46 to participate in that discussion.

📣 Would you like to showcase your project to the Qiskit community? A couple of things you can do to raise awareness for your project:

Great having you as a part of the ecosystem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready submission Project submission
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants