Fix CommutationChecker for 2q Pauli rotations
#13762
Merged
+59
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
added
stable backport potential
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 13115566069Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
ElePT
reviewed
Feb 3, 2025
mergify bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
* Fix ``CommutationChecker`` for 2q rotations + non-cached gates * add reno * compensate for the inability to copy+paste (cherry picked from commit 78e6d3d)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
* Fix ``CommutationChecker`` for 2q rotations + non-cached gates * add reno * compensate for the inability to copy+paste (cherry picked from commit 78e6d3d) Co-authored-by: Julien Gacon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13742.
Details and comments
Fix a bug
CommutationCheckerfor[2q Pauli rotations, a gate that is not in the cache], such as[RXX, U]. The issue was that the parameters of the Pauli rotations were set to[]because we assumed we can find the relation in the cache. However that's obviously not true, as there are gates that are neither rotations, nor in the cache.