Add default translation stage plugin
#13794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelishman
added
on hold
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 13168256573Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This is added to give us semantic room to play with the default translation algorithm during the 2.x series. It starts life as an alias to `translator`, but may change to improve support for fractional-gate translation, more optimized synthesis routines, or discrete-basis translations (like a SK-based 1q translator for logical backends). This makes it programmatically possible to distinguish the "default" plugin choice from an explicit "translator" choice, even when (as right now) those are the same thing. Note that `pass_manager_config` uses `None` as an implicit default, but we active suggest using the plugin-stage getters, which need an actual plugin name.
jakelishman
force-pushed
the
default-translation
branch
from
5190941 to
fa26efb
Compare
|
Now rebased over |
ElePT
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
I am usually triggered by things like this but even after reviewing the new docs I didn't realize that the translation stage was missing a default plugin. I think the change looks good and makes sense (but I will leave the PR around for a bit in case anyone has further opinions)
Cryoris
approved these changes
Feb 6, 2025
|
Ha, I think we've got quite some way to go still til then, but this at least gives us semantic leeway to make changes to the algorithm we use by default to move that way. |
jakelishman
added a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Feb 6, 2025
This is added for a similar reason as the recent `default` translation-stage plugin (Qiskitgh-13794). We currently have no plans to change the default routing method, if not only because the `default` layout plugin does routing most of the time, but this makes the semantics of "just use the default method" clearer.
jakelishman
added a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Feb 6, 2025
This is added for a similar reason as the recent `default` translation-stage plugin (Qiskitgh-13794). We currently have no plans to change the default routing method, if not only because the `default` layout plugin does routing most of the time, but this makes the semantics of "just use the default method" clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is added to give us semantic room to play with the default translation algorithm during the 2.x series. It starts life as an alias to
translator, but may change to improve support for fractional-gate translation, more optimized synthesis routines, or discrete-basis translations (like a SK-based 1q translator for logical backends).This makes it programmatically possible to distinguish the "default" plugin choice from an explicit "translator" choice, even when (as right now) those are the same thing. Note that
pass_manager_configusesNoneas an implicit default, but we active suggest using the plugin-stage getters, which need an actual plugin name.Details and comments
Close #13788.
Built on top of the enhanced documentation #13620.