-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screenshot taken when test passes, while config is set to "on:error" #59
Comments
Hey @OlllllllO I just ran into this problem today and well and have figured out the fix. A PR exists for this fix (#51) but has not been reviewed or merged Update ./node_modules/wdio-timeline-reporter/build/timeline-service.js at line 82
The issue is that the current code only passes the test object into afterTest(). This does not contain any information on if the test passed or failed. That is contained in the 3rd parameter object. So by adding those parameters to the method and updating the if statement we can correctly determine if the test was successful or not. |
@alexbradford3 |
@ansarise I never received an update but I did fork this repo, make the change, and published it on NPM. I'm using this version and able to set up my automation to use the "on:error: screenshot strategy. You can find it on my profile. Feel free to try using it and see if it resolves your issues. |
A screenshot is taken when the test passes.
// wdio.conf.js
// wdio-0-0-timeline-reporter.log
The text was updated successfully, but these errors were encountered: