Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to set credentials #26

Open
jtpio opened this issue Sep 3, 2024 · 1 comment
Open

Document how to set credentials #26

jtpio opened this issue Sep 3, 2024 · 1 comment

Comments

@jtpio
Copy link
Member

jtpio commented Sep 3, 2024

It would be useful to add some documentation for setting custom credentials, when using a released version of jupydrive-s3 (not local).

Currently it looks like there is some logic relying in the use of process.env here:

jupydrive-s3/src/index.ts

Lines 93 to 104 in 7b79ecf

bucket: process.env.JP_S3_BUCKET ?? 'jupyter-drives-test-bucket-1',
root: process.env.JP_S3_ROOT ?? '',
config: {
forcePathStyle: true,
endpoint: process.env.JP_S3_ENDPOINT ?? 'https://example.com/s3',
region: process.env.JP_S3_REGION ?? 'eu-west-1',
credentials: {
accessKeyId:
process.env.JP_S3_ACCESS_KEY_ID ?? 'abcdefghijklmnopqrstuvwxyz',
secretAccessKey:
process.env.JP_S3_SECRET_ACCESS_KEY ??
'SECRET123456789abcdefghijklmnopqrstuvwxyz'

@cesnikb
Copy link

cesnikb commented Jan 24, 2025

I'm having issues configuring credentials on released version as well. Documentation for it would come in handy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants