This repository has been archived by the owner on Dec 18, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix #170 .
The previous gradient of a circuit is a vector of circuit parameter gradients. This causes the problem in #170 .
The gradient of a circuit now is a Yao Block instead of a vector type.
This solution is not yet perfect, the best return type should be
Tagent{<:AbstractBlock}
, because when you want to accumulate gradients, the block arithmetics does not do the right thing. As a result, you still need a patch for Zygote: