From e3799133a8f05112a706604c1e2535cf1d3247c3 Mon Sep 17 00:00:00 2001
From: Locria Cyber <74560659+locriacyber@users.noreply.github.com>
Date: Mon, 27 Jun 2022 06:40:55 +0800
Subject: [PATCH 1/3] Make PKGBUILD much less flaky and ideompotent

---
 archlinux/.gitignore |  3 +++
 archlinux/PKGBUILD   | 40 ++++++++++++++++++++++++++++------------
 2 files changed, 31 insertions(+), 12 deletions(-)
 create mode 100644 archlinux/.gitignore

diff --git a/archlinux/.gitignore b/archlinux/.gitignore
new file mode 100644
index 00000000..79de598d
--- /dev/null
+++ b/archlinux/.gitignore
@@ -0,0 +1,3 @@
+pkg/
+src/
+*.tar.zst
diff --git a/archlinux/PKGBUILD b/archlinux/PKGBUILD
index cf69505f..ad349faf 100644
--- a/archlinux/PKGBUILD
+++ b/archlinux/PKGBUILD
@@ -1,5 +1,4 @@
 pkgname=(qubes-vm-gui qubes-vm-pulseaudio)
-pkgver=$(cat version)
 pkgrel=10
 epoch=
 pkgdesc="The Qubes GUI Agent for AppVMs"
@@ -8,8 +7,8 @@ url="http://qubes-os.org/"
 license=('GPL')
 groups=()
 makedepends=(pkg-config make gcc patch git automake autoconf libtool
-			'pulseaudio<=16.1'
-			xorg-server-devel xorg-util-macros libxcomposite libxt pixman lsb-release
+			'pulseaudio'
+			xorg-server-devel xorg-util-macros libxcomposite libxt pixman
 			qubes-vm-gui-common qubes-libvchan qubes-db-vm
 			)
 checkdepends=()
@@ -21,21 +20,39 @@ backup=()
 options=()
 changelog=
 
-source=(PKGBUILD-z-qubes-session.sh)
+source=()
+md5sums=()
 
 noextract=()
-md5sums=() #generate with 'makepkg -g'
-pa_ver=$((pkg-config --modversion libpulse 2>/dev/null || echo 0.0) | cut -f 1 -d "-")
+pa_ver=16.1 #specify this manually please
+# If using pkg-config, you must update libpulse first.
+#pa_ver=$((pkg-config --modversion libpulse 2>/dev/null || echo 0.0) | cut -f 1 -d "-")
+
+export PA_VER_FULL=$pa_ver
+
+if [ -e archlinux ] # on no, at repo root
+then
+    echo Do not run 'makepkg' at repo root! >&2
+    cd archlinux
+fi
+
+pkgver=$(cat $startdir/../version)
+
+clean() {
+    rm $srcdir/* -r || true
+}
 
 build() {
 
-for source in Makefile appvm-scripts gui-common include pulse gui-agent common xf86-input-mfndev xf86-video-dummy xf86-qubes-common window-icon-updater version; do
-  (ln -s $srcdir/../$source $srcdir/$source)
+rm $srcdir/PKGBUILD-z-qubes-session.sh || true
+cp $startdir/PKGBUILD-z-qubes-session.sh $srcdir/
+for source in Makefile appvm-scripts gui-common include pulse gui-agent common xf86-input-mfndev xf86-video-dummy xf86-qubes-common window-icon-updater version; do    
+  rm $source -r || true
+  cp -r $startdir/../$source $source
 done
 
-pa_ver=$((pkg-config --modversion libpulse 2>/dev/null || echo 0.0) | cut -f 1 -d "-")
 
-rm -f pulse/pulsecore
+rm -rf pulse/pulsecore
 ln -s pulsecore-$pa_ver pulse/pulsecore
 
 # Bug fixes : /var/run/console depends on pam_console, which is fedora specific
@@ -71,9 +88,8 @@ install -D $srcdir/PKGBUILD-z-qubes-session.sh $pkgdir/etc/X11/xinit/xinitrc.d/z
 package_qubes-vm-pulseaudio() {
 
 pkgdesc="Pulseaudio support for Qubes VM"
-depends=('alsa-lib' 'alsa-utils' 'pulseaudio-alsa' 'pulseaudio<=16.1')
+depends=('alsa-lib' 'alsa-utils' 'pulseaudio-alsa' 'pulseaudio')
 install=PKGBUILD-pulseaudio.install
-pa_ver=$((pkg-config --modversion libpulse 2>/dev/null || echo 0.0) | cut -f 1 -d "-")
 
 make install-pulseaudio DESTDIR=$pkgdir PA_VER=$pa_ver LIBDIR=/usr/lib USRLIBDIR=/usr/lib SYSLIBDIR=/usr/lib
 

From 140527dbbb3b9e8d050941d26f2a1fd7037ce3c9 Mon Sep 17 00:00:00 2001
From: Locria Cyber <74560659+locriacyber@users.noreply.github.com>
Date: Tue, 28 Jun 2022 11:34:03 +0800
Subject: [PATCH 2/3] Make PKGBUILD better

---
 archlinux/PKGBUILD | 49 +++++++++++++++++++++++++++++++---------------
 1 file changed, 33 insertions(+), 16 deletions(-)

diff --git a/archlinux/PKGBUILD b/archlinux/PKGBUILD
index ad349faf..7ca05dde 100644
--- a/archlinux/PKGBUILD
+++ b/archlinux/PKGBUILD
@@ -6,11 +6,6 @@ arch=("x86_64")
 url="http://qubes-os.org/"
 license=('GPL')
 groups=()
-makedepends=(pkg-config make gcc patch git automake autoconf libtool
-			'pulseaudio'
-			xorg-server-devel xorg-util-macros libxcomposite libxt pixman
-			qubes-vm-gui-common qubes-libvchan qubes-db-vm
-			)
 checkdepends=()
 optdepends=()
 provides=()
@@ -24,11 +19,29 @@ source=()
 md5sums=()
 
 noextract=()
-pa_ver=16.1 #specify this manually please
-# If using pkg-config, you must update libpulse first.
-#pa_ver=$((pkg-config --modversion libpulse 2>/dev/null || echo 0.0) | cut -f 1 -d "-")
 
-export PA_VER_FULL=$pa_ver
+# Use envvar $PA_VER_FULL to specify pulseaudio version manually
+# e.g. PA_VER_FULL=16.1 makepkg -s
+if [ -z $PA_VER_FULL ]
+then
+    pa_ver=$(pkg-config --modversion libpulse)
+    if [ ! $? -eq 0 ]; then
+        echo "Cannot find libpulse version with pkg-config."
+        echo "Please specify version manually with PA_VER_FULL."
+        exit 1
+    fi
+    pa_ver=$(echo $pa_ver | cut -f 1 -d "-")
+    export PA_VER_FULL=$pa_ver
+else
+    pa_ver=$PA_VER_FULL
+fi
+
+makedepends=(pkg-config make gcc patch git automake autoconf libtool
+			"pulseaudio=$pa_ver"
+			xorg-server-devel xorg-util-macros libxcomposite libxt pixman
+			qubes-vm-gui-common qubes-libvchan qubes-db-vm
+			)
+
 
 if [ -e archlinux ] # on no, at repo root
 then
@@ -39,21 +52,25 @@ fi
 pkgver=$(cat $startdir/../version)
 
 clean() {
-    rm $srcdir/* -r || true
+    rm -r $srcdir/* || true
 }
 
 build() {
 
 rm $srcdir/PKGBUILD-z-qubes-session.sh || true
 cp $startdir/PKGBUILD-z-qubes-session.sh $srcdir/
-for source in Makefile appvm-scripts gui-common include pulse gui-agent common xf86-input-mfndev xf86-video-dummy xf86-qubes-common window-icon-updater version; do    
-  rm $source -r || true
+for source in Makefile appvm-scripts gui-common include pulse gui-agent common xf86-input-mfndev xf86-video-dummy xf86-qubes-common window-icon-updater version; do
+  if [ -e "$source" ]; then rm -r "$source"; fi
   cp -r $startdir/../$source $source
 done
 
-
-rm -rf pulse/pulsecore
-ln -s pulsecore-$pa_ver pulse/pulsecore
+pulsecore_dir="pulse/pulsecore-$pa_ver"
+if [ ! -d $pulsecore_dir ]; then
+    echo "Invalid pulsecore_dir: $pulsecore_dir"
+    exit 2
+fi
+if [ -e pulse/pulsecore ]; then rm -r pulse/pulsecore; fi
+ln -s $(realpath "$pulsecore_dir") pulse/pulsecore
 
 # Bug fixes : /var/run/console depends on pam_console, which is fedora specific
 # As a consequece, /var/run/console does not exists and qubes-gui-agent will always fail
@@ -88,7 +105,7 @@ install -D $srcdir/PKGBUILD-z-qubes-session.sh $pkgdir/etc/X11/xinit/xinitrc.d/z
 package_qubes-vm-pulseaudio() {
 
 pkgdesc="Pulseaudio support for Qubes VM"
-depends=('alsa-lib' 'alsa-utils' 'pulseaudio-alsa' 'pulseaudio')
+depends=('alsa-lib' 'alsa-utils' 'pulseaudio-alsa' "pulseaudio=$pa_ver")
 install=PKGBUILD-pulseaudio.install
 
 make install-pulseaudio DESTDIR=$pkgdir PA_VER=$pa_ver LIBDIR=/usr/lib USRLIBDIR=/usr/lib SYSLIBDIR=/usr/lib

From f7508939cb51422393e5059d9d1220e233fd55d3 Mon Sep 17 00:00:00 2001
From: Locria Cyber <74560659+locriacyber@users.noreply.github.com>
Date: Tue, 28 Jun 2022 11:43:36 +0800
Subject: [PATCH 3/3] Remove clean() from PKGBUILD

---
 archlinux/PKGBUILD | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/archlinux/PKGBUILD b/archlinux/PKGBUILD
index 7ca05dde..2db42892 100644
--- a/archlinux/PKGBUILD
+++ b/archlinux/PKGBUILD
@@ -51,10 +51,6 @@ fi
 
 pkgver=$(cat $startdir/../version)
 
-clean() {
-    rm -r $srcdir/* || true
-}
-
 build() {
 
 rm $srcdir/PKGBUILD-z-qubes-session.sh || true