Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved search results #127

Open
Decencies opened this issue Jul 20, 2023 · 2 comments
Open

improved search results #127

Decencies opened this issue Jul 20, 2023 · 2 comments
Labels
enhancement New feature or request user interface affects the enigma ui

Comments

@Decencies
Copy link
Contributor

When searching for symbol references, the search box should how snippets of code which reference the symbol for ease of use. (https://grep.app has a fantastic implementation of this)

@ix0rai
Copy link
Member

ix0rai commented Jul 23, 2023

how do you propose we handle the biggest issue with this -- we don't have access to the source
we would have to decompile the full jar in order to implement this feature, and I'm not sure what a good way to go about that is

@ix0rai ix0rai added enhancement New feature or request user interface affects the enigma ui labels Jul 23, 2023
@Decencies
Copy link
Contributor Author

how do you propose we handle the biggest issue with this -- we don't have access to the source

we would have to decompile the full jar in order to implement this feature, and I'm not sure what a good way to go about that is

Literally just decompile it like you said, on a another thread. The source code isn't going to change much anyways, except for renaming some symbols.

There isn't much optimisations you can do, but remember this is a one-time operation per project. It may take a while initially, but at least we aren't wasting computational power on re-indexing and decompiling the JAR every time you load the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request user interface affects the enigma ui
Projects
None yet
Development

No branches or pull requests

2 participants