Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client-fallback tag entries inside client-fallback tags are incorrectly loaded depending of load order #235

Open
EnnuiL opened this issue Dec 17, 2022 · 1 comment
Labels
bug Something isn't working library: data Related to the data library.

Comments

@EnnuiL
Copy link
Contributor

EnnuiL commented Dec 17, 2022

Depending on which tag is loaded first, a client-fallback tag may accidentally load a client-fallback tag entry as a regular tag, and therefore, that tag is loaded with nothingness inside; Flipping the involved tags, however, results into it working once again

This can be reproduced on QSL 1.19.3, with this testmod consistently reproducing it. A victim of this bug on production is the 1.19.3 port of Ok Zoomer and its interaction with LibZoomer

I've attempted to debug this, but unfortunately, my mind doesn't grasp well the tag module codebase; If someone else wants to give a try? I'd appreciate it! If not? welp, sorry aurora

@EnnuiL EnnuiL added bug Something isn't working library: data Related to the data library. labels Dec 17, 2022
@EnnuiL
Copy link
Contributor Author

EnnuiL commented Jun 9, 2023

QSL 6.0.0 has fixed the Ok Zoomer case, which is either a sign that it isn't really consistent between versions or that it might have been fixed! Unfortunately I can't test it right now, but yeah, this looks promising!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working library: data Related to the data library.
Projects
None yet
Development

No branches or pull requests

1 participant