From 5a804a74b1679136dd6fed176bddcd187b3ad68b Mon Sep 17 00:00:00 2001
From: mamadoudicko <mamadoudicko100@gmail.com>
Date: Mon, 6 Nov 2023 11:40:02 +0100
Subject: [PATCH] fix: allow to change model bro brain settings tab

---
 .../components/GeneralInformation/GeneralInformation.tsx | 1 -
 .../components/ModelSelection/ModelSelection.tsx         | 9 +++++----
 .../components/SettingsTab/hooks/useSettingsTab.ts       | 2 +-
 frontend/lib/context/BrainProvider/types.ts              | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/frontend/app/brains-management/[brainId]/components/BrainManagementTabs/components/SettingsTab/components/GeneralInformation/GeneralInformation.tsx b/frontend/app/brains-management/[brainId]/components/BrainManagementTabs/components/SettingsTab/components/GeneralInformation/GeneralInformation.tsx
index d148392bfaa0..66bb65959b3f 100644
--- a/frontend/app/brains-management/[brainId]/components/BrainManagementTabs/components/SettingsTab/components/GeneralInformation/GeneralInformation.tsx
+++ b/frontend/app/brains-management/[brainId]/components/BrainManagementTabs/components/SettingsTab/components/GeneralInformation/GeneralInformation.tsx
@@ -86,7 +86,6 @@ export const GeneralInformation = (
           <Radio
             items={brainStatusOptions}
             label={t("brain_status_label", { ns: "brain" })}
-            value={status}
             className="flex-1 justify-between w-[50%]"
             {...register("status")}
           />
diff --git a/frontend/app/brains-management/[brainId]/components/BrainManagementTabs/components/SettingsTab/components/ModelSelection/ModelSelection.tsx b/frontend/app/brains-management/[brainId]/components/BrainManagementTabs/components/SettingsTab/components/ModelSelection/ModelSelection.tsx
index 670487ec7c58..0d3719a5c68b 100644
--- a/frontend/app/brains-management/[brainId]/components/BrainManagementTabs/components/SettingsTab/components/ModelSelection/ModelSelection.tsx
+++ b/frontend/app/brains-management/[brainId]/components/BrainManagementTabs/components/SettingsTab/components/ModelSelection/ModelSelection.tsx
@@ -47,11 +47,12 @@ export const ModelSelection = (props: ModelSelectionProps): JSX.Element => {
         <select
           id="model"
           disabled={!hasEditRights}
-          {...register("model")}
+          {...register("model", {
+            onChange: () => {
+              void handleSubmit(false);
+            },
+          })}
           className="px-5 py-2 dark:bg-gray-700 bg-gray-200 rounded-md"
-          onChange={() => {
-            void handleSubmit(false); // Trigger form submission
-          }}
         >
           {accessibleModels.map((availableModel) => (
             <option value={availableModel} key={availableModel}>
diff --git a/frontend/app/brains-management/[brainId]/components/BrainManagementTabs/components/SettingsTab/hooks/useSettingsTab.ts b/frontend/app/brains-management/[brainId]/components/BrainManagementTabs/components/SettingsTab/hooks/useSettingsTab.ts
index 35ddd0ef541d..16b5676a08f2 100644
--- a/frontend/app/brains-management/[brainId]/components/BrainManagementTabs/components/SettingsTab/hooks/useSettingsTab.ts
+++ b/frontend/app/brains-management/[brainId]/components/BrainManagementTabs/components/SettingsTab/hooks/useSettingsTab.ts
@@ -98,7 +98,7 @@ export const useSettingsTab = ({ brainId }: UseSettingsTabProps) => {
     }
 
     setTimeout(() => {
-      if (brain.model !== undefined) {
+      if (brain.model !== undefined && brain.model !== null) {
         setValue("model", brain.model);
       }
     }, 50);
diff --git a/frontend/lib/context/BrainProvider/types.ts b/frontend/lib/context/BrainProvider/types.ts
index 5a36ed73698f..6191e4f6691f 100644
--- a/frontend/lib/context/BrainProvider/types.ts
+++ b/frontend/lib/context/BrainProvider/types.ts
@@ -13,10 +13,10 @@ export type Brain = {
   name: string;
   documents?: Document[];
   status?: BrainAccessStatus;
-  model?: Model;
+  model?: Model | null;
   max_tokens?: number;
   temperature?: number;
-  openai_api_key?: string;
+  openai_api_key?: string | null;
   description?: string;
   prompt_id?: string | null;
 };