[TabManager]: Some notes

[JHooverman]

Thank you, that you have created the Tab-Manager plugin or QupZilla. After using it for a while, some questions appeared:

(1) Tooltips
Please consider to add some tooltips to the plugin. This will improve the usability of the plugin.

(2) Selection status

(a) If I select one tab in a group, the selection looks like this

This is OK.

(b) If I select a group (here: opensuse.org), the selection status looks like this

This is after one click on opensuse.org

This should be the expected result after selecting one group

(3) Select a group and move it to a new window

Click on the "green symbol"

The new window will contain the group selected before (here: opensuse.org)

but same tabs in the Tab-Manager as the source window. I would expected, that the new window only contains the tabs in the Tab-Manager of the new window. If you close a tab in the Tab-Manager of the new window, it will be deleted in the source window as well. This should be prevented.

[srazi]

Thank you, that you have created the Tab-Manager plugin or QupZilla.

You're welcome :)

(1) Tooltips

Ok. but I think about moving buttons and combo box to a context menu for having a clean UI. Do you think it fixes this issue?

(2) Selection status
(b) If I select a group (here: opensuse.org), the selection status looks like this

I think this is a bug of Qt or Desktop or theme or ... ? I have always lots of similar issues on Ubuntu and its default theme with Qt applications, but some other themes (for me default theme of root user) work correct.

(3) Select a group and move it to a new window

The TabManager always (in both window mode and sidebar mode) manages all QZ windows, because of this also if you set it in sidebar mode again you'll see all tabs of all windows. The behaviour that you saw was expected.

[nowrep]

Oh and last note: When will it be ready to merge to main repo? The same for FCM?

[srazi]

@nowrep: I think FCM is in a stable situation and can be merged, maybe it needs just some clean up.

For TabManager I'll try to fix most of known issues, ASAP.

[JHooverman]

1) Tooltips
Ok. but I think about moving buttons and combo box to a context menu for having a clean UI. Do you think it fixes this issue?
Well, let's give it a try!

[srazi]

@JHooverman: Please check the UI of TabManager in current git.

[JHooverman]

Yes, I'll do, but probably not before next weekend. Thank you!

[JHooverman]

Wouldn't it make sense to have a checkbox like the other panels, if the TabManager is in the sidebar mode, please see screenshot:

[nowrep]

It already is checkbox, but it also has icon. So it looks this special :)

[JHooverman]

I see....:-)

BTW, the UI looks very good:

[srazi]

I need some help on this:
I used the word checked instead of selected because actions are just applied to checked items, but I think there is some inconsistency.

My solutions are:

1. Don't show context menu for unchecked items.
2. As (1), but if there are no checked items then on right-click we check the item under mouse and show context-menu.
3. As (2), and also we enable context-menu for parent item but add actions related to the parent item under mouse in a submenu of the context-menu.

What's your idea?

[JHooverman]

For me the current implementation is intuitive and I had no problems to use the TabManager. So, I would keep it as it is.

[srazi]

UPDATE: Oops... I was wrong, (2) Selection status is a valid issue but just occurs with Qt-5.

EDIT: It seems a Qt-5 bug :/ (I'm using latest Qt version) for me it's reproducible on qupzilla:restore page.

[srazi]

I opened a bug report: https://bugreports.qt-project.org/browse/QTBUG-43473

[nowrep]

One thing: there is no way to open the tab manager when user has hidden statusbar.
Otherwise, it's awesome plugin. Let's add option to completely disable default tabbar, so this can be used as alternative for "vertical tabs", and close this issue.

[srazi]

@nowrep

One thing: there is no way to open the tab manager when user has hidden statusbar.

OK thanks, I'll add an option for it to Tools menu. (BTW, as a workaround one can use its shortcut "Ctrl+Shift+M")

Otherwise, it's awesome plugin. Let's add option to completely disable default tabbar, so this can be used as alternative for "vertical tabs", and close this issue.

Good idea!
Well, Indeed I'm implementing a session manager as a part of this plugin, then do you think I should add an option to enable/disable the session manager?