Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/build/null in Chrome #86

Closed
sotasan opened this issue Apr 3, 2024 · 5 comments
Closed

/build/null in Chrome #86

sotasan opened this issue Apr 3, 2024 · 5 comments

Comments

@sotasan
Copy link

sotasan commented Apr 3, 2024

After creating a new Astro project and adding Qwik, I have added the example Counter:

import { component$, useSignal } from "@builder.io/qwik";

export const Counter = component$(() => {
    const counter = useSignal(0);

    return <button onClick$={() => counter.value++}>{counter.value}</button>;
});

After interacting with it in the production build, it fetches the framework and component correctly. But in only in Chrome it also tries to load http://localhost:4321/build/null, otherwise the component is working correctly:

grafik
@thejackshelton
Copy link
Member

Hey @sotasan! I believe this is actually a bug in the Qwik core service worker. It seems to make an extra null fetch when it shouldn't be.

I would make an issue in the Qwik repo for this. Also side note: I would explicitly mention the Qwik core service worker, as there is another implementation in Qwik City that is being deprecated in the near future.

@sotasan
Copy link
Author

sotasan commented Apr 5, 2024

Okay thanks, I have created the Issue in QwikDev/qwik#6088.

@thejackshelton
Copy link
Member

thejackshelton commented Apr 5, 2024

Thanks for that! I will go ahead and investigate this in core. Closing here.

@thejackshelton
Copy link
Member

thejackshelton commented Apr 5, 2024

@sotasan I have made a PR for a fix in core 😄

@sotasan
Copy link
Author

sotasan commented Apr 6, 2024

Thanks for fixing the Issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants