From a2fade7e276bc2474f586ba1a588bf6b90881d05 Mon Sep 17 00:00:00 2001 From: Dane Pitkin <48041712+danepitkin@users.noreply.github.com> Date: Wed, 26 Jul 2023 21:10:32 -0400 Subject: [PATCH] GH-36885: [Java][Docs] Add substrait dependency to maven build profiles (#36899) ### Rationale for this change The Java JNI dataset module recently included the Substrait module as a dependency. The dependency was added to the CI scripts, but not added to the build profiles and documentation yet. ### What changes are included in this PR? - Update maven build profiles - Update Java build documentation ### Are these changes tested? I tested locally on MacOS and was able to reproduce + fix with this change. ### Are there any user-facing changes? No * Closes: #36885 Authored-by: Dane Pitkin Signed-off-by: Sutou Kouhei --- docs/source/developers/java/building.rst | 2 ++ java/pom.xml | 2 ++ 2 files changed, 4 insertions(+) diff --git a/docs/source/developers/java/building.rst b/docs/source/developers/java/building.rst index 5b525d467731e..9d773f051451e 100644 --- a/docs/source/developers/java/building.rst +++ b/docs/source/developers/java/building.rst @@ -219,6 +219,7 @@ CMake -DARROW_ORC=ON \ -DARROW_PARQUET=ON \ -DARROW_S3=ON \ + -DARROW_SUBSTRAIT=ON \ -DARROW_USE_CCACHE=ON \ -DCMAKE_BUILD_TYPE=Release \ -DCMAKE_INSTALL_LIBDIR=lib/ \ @@ -258,6 +259,7 @@ CMake -DARROW_ORC=OFF ^ -DARROW_PARQUET=ON ^ -DARROW_S3=ON ^ + -DARROW_SUBSTRAIT=ON ^ -DARROW_USE_CCACHE=ON ^ -DARROW_WITH_BROTLI=ON ^ -DARROW_WITH_LZ4=ON ^ diff --git a/java/pom.xml b/java/pom.xml index ccb2a2b72d5e6..e997406f0238d 100644 --- a/java/pom.xml +++ b/java/pom.xml @@ -1022,6 +1022,7 @@ -DARROW_ORC=${ARROW_ORC} -DARROW_PARQUET=${ARROW_PARQUET} -DARROW_S3=ON + -DARROW_SUBSTRAIT=${ARROW_DATASET} -DARROW_USE_CCACHE=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_LIBDIR=lib/${os.detected.arch} @@ -1131,6 +1132,7 @@ -DARROW_ORC=${ARROW_ORC} -DARROW_PARQUET=${ARROW_PARQUET} -DARROW_S3=ON + -DARROW_SUBSTRAIT=${ARROW_DATASET} -DARROW_USE_CCACHE=ON -DARROW_WITH_BROTLI=ON -DARROW_WITH_LZ4=ON