Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warpSet: current jitter is more than 1% of sd #53

Open
SamGG opened this issue Aug 7, 2024 · 0 comments
Open

warpSet: current jitter is more than 1% of sd #53

SamGG opened this issue Aug 7, 2024 · 0 comments

Comments

@SamGG
Copy link

SamGG commented Aug 7, 2024

Hi,

While diving into warpSet, I noticed the jittering. The comment claims adding %1 of sd aka a small amount of noise. Unfortunately, sd is not calculated and the doc of jitter says that the default leads to d/5 where d is about the smallest difference between x values (factor being 1). When there are 2 landmarks, jitter generates a uniform random number between -20% and +20% of the gap between landmarks, which quite huge IMO.

I know you are considering warpSet and gaussNorm as unsupported, but I wanted to let you know.

I added , factor = 0.1 for testing.

Best.

flowStats/R/warpSet.R

Lines 766 to 767 in fabb131

#add a small amount of noise 1% of sd (robust) to the target landmarks
capture.output(regDens <- landmarkreg(fdobj, landmarks, x0marks=apply(landmarks,2,jitter)[rownames(landmarks)%in%target,],WfdPar=WfdPar,

@SamGG SamGG changed the title jitter is more than 1% of sd warpSet: jitter is more than 1% of sd Aug 7, 2024
@SamGG SamGG changed the title warpSet: jitter is more than 1% of sd warpSet: current jitter is more than 1% of sd Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant