From 64b499efab4f2c772de35d0f639a93b45e799a60 Mon Sep 17 00:00:00 2001
From: Adhitya Logan <alogan@redhat.com>
Date: Wed, 4 Oct 2023 17:17:02 -0700
Subject: [PATCH] return jsonify() from api rather than json.dumps()

---
 dashboard/src/t5gweb/api.py | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/dashboard/src/t5gweb/api.py b/dashboard/src/t5gweb/api.py
index 003ea3a..a4aea7d 100644
--- a/dashboard/src/t5gweb/api.py
+++ b/dashboard/src/t5gweb/api.py
@@ -1,7 +1,7 @@
 """API endpoints for t5gweb"""
 import json
 
-from flask import Blueprint, request
+from flask import Blueprint, request, jsonify
 from flask_login import login_required
 from t5gweb.cache import (
     get_bz_details,
@@ -50,26 +50,26 @@ def refresh(data_type):
     cfg = set_cfg()
     if data_type == "cards":
         get_cards(cfg)
-        return {"caching cards": "ok"}
+        return jsonify({"caching cards": "ok"})
     elif data_type == "cases":
         get_cases(cfg)
-        return {"caching cases": "ok"}
+        return jsonify({"caching cases": "ok"})
     elif data_type == "details":
         get_case_details(cfg)
-        return {"caching details": "ok"}
+        return jsonify({"caching details": "ok"})
     elif data_type == "bugs":
         get_bz_details(cfg)
     elif data_type == "escalations":
         get_escalations(cfg)
-        return {"caching escalations": "ok"}
+        return jsonify({"caching escalations": "ok"})
     elif data_type == "watchlist":
         get_watchlist(cfg)
-        return {"caching watchlist": "ok"}
+        return jsonify({"caching watchlist": "ok"})
     elif data_type == "issues":
         get_issue_details(cfg)
-        return {"caching issues": "ok"}
+        return jsonify({"caching issues": "ok"})
     else:
-        return {"error": "unknown data type: {}".format(data_type)}
+        return jsonify({"error": "unknown data type: {}".format(data_type)})
 
 
 @BP.route("/cards")
@@ -77,7 +77,7 @@ def refresh(data_type):
 def show_cards():
     """Retrieves all cards"""
     cards = redis_get("cards")
-    return cards
+    return jsonify(cards)
 
 
 @BP.route("/cases")
@@ -85,7 +85,7 @@ def show_cards():
 def show_cases():
     """Retrieves all cases"""
     cases = redis_get("cases")
-    return cases
+    return jsonify(cases)
 
 
 @BP.route("/bugs")
@@ -93,7 +93,7 @@ def show_cases():
 def show_bugs():
     """Retrieves all bugs"""
     bugs = redis_get("bugs")
-    return bugs
+    return jsonify(bugs)
 
 
 @BP.route("/escalations")
@@ -101,7 +101,7 @@ def show_bugs():
 def show_escalations():
     """Retrieves all escalations"""
     escalations = redis_get("escalations")
-    return json.dumps(escalations)
+    return jsonify(escalations)
 
 
 @BP.route("/watchlist")
@@ -109,7 +109,7 @@ def show_escalations():
 def show_watched():
     """Retrieves all cases on the watchlist"""
     watchlist = redis_get("watchlist")
-    return json.dumps(watchlist)
+    return jsonify(watchlist)
 
 
 @BP.route("/details")
@@ -117,7 +117,7 @@ def show_watched():
 def show_details():
     """Retrieves CritSit and Group Name for each case"""
     details = redis_get("details")
-    return json.dumps(details)
+    return jsonify(details)
 
 
 @BP.route("/issues")
@@ -125,11 +125,11 @@ def show_details():
 def show_issues():
     """Retrieves all JIRA issues associated with open cases"""
     issues = redis_get("issues")
-    return json.dumps(issues)
+    return jsonify(issues)
 
 
 @BP.route("/stats")
 @login_required
 def show_stats():
     stats = generate_stats()
-    return stats
+    return jsonify(stats)