Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Toleration configuration for device-plugin daemonset #25

Open
c-fteixeira opened this issue Dec 6, 2024 · 5 comments
Open

Comments

@c-fteixeira
Copy link

Suggestion Description

Currently it is not possible to add tolerations to the daemonset created based on the DeviceConfig.

Operating System

No response

GPU

No response

ROCm Component

No response

@sajmera-pensando
Copy link
Collaborator

Thanks @c-fteixeira for filing this feature request. Could you please provide a bit more detail about the use case for which you need to add Tolerations to the DevicePlugin daemonset?

@ESlam-Yousry
Copy link

@sajmera-pensando there's a use case when you have some taints for your worker nodes,
For example { "effect": "NoSchedule", "key": "amd.com/gpu", "value": "present" }
so we need to allow daemonsets to tolerate with these taints

@taddeusb90
Copy link

@sajmera-pensando could you please point me to the repo that contains the internal reconciliation logic for tolerations? If it's not supported i would like to add support for it

@sajmera-pensando
Copy link
Collaborator

Hi @ESlam-Yousry @taddeusb90 , we will add support for it and will update this issue once its available. Thanks.

@ESlam-Yousry
Copy link

@sajmera-pensando Thanks! ,Super excited to have this ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants