You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 26, 2024. It is now read-only.
I've been porting the algorithm in ihipOccupancyMaxActiveBlocksPerMultiprocessor to Julia to use for our own occupancy calculations, and noticed a potential typo in:
I assume this should actually be if (wrkGrpInfo->usedVGPRs_ > 0) {, since we want to ensure we don't get a divide-by-zero when no VGPRs are used? Obviously such kernels probably don't actually need their occupancy calculated, but I figured it was worth reporting in case someone has run into this!
The text was updated successfully, but these errors were encountered:
I've been porting the algorithm in
ihipOccupancyMaxActiveBlocksPerMultiprocessor
to Julia to use for our own occupancy calculations, and noticed a potential typo in:https://github.com/ROCm-Developer-Tools/hipamd/blob/05e3016405bdaec0b8acfe8378df968dd02136d5/src/hip_platform.cpp#L351
I assume this should actually be
if (wrkGrpInfo->usedVGPRs_ > 0) {
, since we want to ensure we don't get a divide-by-zero when no VGPRs are used? Obviously such kernels probably don't actually need their occupancy calculated, but I figured it was worth reporting in case someone has run into this!The text was updated successfully, but these errors were encountered: