Skip to content
This repository has been archived by the owner on Jan 26, 2024. It is now read-only.

Possible bug in occupancy calculation #58

Open
jpsamaroo opened this issue Jan 25, 2023 · 1 comment
Open

Possible bug in occupancy calculation #58

jpsamaroo opened this issue Jan 25, 2023 · 1 comment

Comments

@jpsamaroo
Copy link

I've been porting the algorithm in ihipOccupancyMaxActiveBlocksPerMultiprocessor to Julia to use for our own occupancy calculations, and noticed a potential typo in:

https://github.com/ROCm-Developer-Tools/hipamd/blob/05e3016405bdaec0b8acfe8378df968dd02136d5/src/hip_platform.cpp#L351

I assume this should actually be if (wrkGrpInfo->usedVGPRs_ > 0) {, since we want to ensure we don't get a divide-by-zero when no VGPRs are used? Obviously such kernels probably don't actually need their occupancy calculated, but I figured it was worth reporting in case someone has run into this!

@jatinx
Copy link

jatinx commented May 17, 2023

Thanks for pointing it out will raise it internally

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants