Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Do not recompile the SPU LLVM cache every boot #10129

Open
dio-gh opened this issue Apr 16, 2021 · 6 comments
Open

[Feature Request] Do not recompile the SPU LLVM cache every boot #10129

dio-gh opened this issue Apr 16, 2021 · 6 comments

Comments

@dio-gh
Copy link
Contributor

dio-gh commented Apr 16, 2021

The title should be sufficiently clear. I'm well aware that the SPU cache version is bumped way more often than the PPU, and that changing certain settings may require a recompilation, but I'd argue that it still happens way less than me launching a given game several times in a row.

It's particularly problematic when testing games. I won't be updating RPCS3 left and right, I'll be relaunching the game a million times over. Recompiling thousands of modules every time, after every crash, for no reason, especially on my PC, is equivalent to torture.

@dio-gh
Copy link
Contributor Author

dio-gh commented Apr 17, 2021

@Nekotekina sorry for the direct mention, but it's only you who can call the shots on this anyways. Is this any feasible to be added?

@Nekotekina
Copy link
Member

There were some obstacles (such as hard-coded values during compilation) which would render SPU LLVM cache useless. Need to carefully examine current state of things, I fixed some of them but can't say for sure that nothing remains.

@dio-gh
Copy link
Contributor Author

dio-gh commented Apr 17, 2021

Sounds moderately promising, thanks.

@dio-gh
Copy link
Contributor Author

dio-gh commented Sep 4, 2021

Has there been any further investigations in the topic since?

@MSuih
Copy link
Member

MSuih commented Sep 5, 2021

This is a duplicate of #10452, I'll close this one as the other ticket includes all caches. And yes, there's been more thought put into this due to savestates.

@MSuih MSuih closed this as completed Sep 5, 2021
@MSuih
Copy link
Member

MSuih commented Sep 5, 2021

Oh, seems like I misread. This isn't about keeping the cache in memory, it's about storing the compiled data to disc along with the uncompiled data to speed up boot.

@MSuih MSuih reopened this Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants