Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External data: sha512 or md5 #641

Closed
SimonRit opened this issue Dec 4, 2024 · 3 comments · Fixed by #660
Closed

External data: sha512 or md5 #641

SimonRit opened this issue Dec 4, 2024 · 3 comments · Fixed by #660
Milestone

Comments

@SimonRit
Copy link
Collaborator

SimonRit commented Dec 4, 2024

We currently have both sha512 and md5 files for external data.
See for example https://github.com/RTKConsortium/RTK/tree/master/test/Input/Bioscan.
Should we keep both? Any opinion @LucasGandel?

@SimonRit SimonRit added this to the RTK 2.7 milestone Dec 4, 2024
@SimonRit
Copy link
Collaborator Author

@LucasGandel, do you remember why we have both sha512 and md5?

@LucasGandel
Copy link
Collaborator

Not sure why, I think we always use sha512, but ITK had both at some point too. Now they moved to .cid : InsightSoftwareConsortium/ITK#3760, maybe we should do the same

@SimonRit
Copy link
Collaborator Author

I think md5 can be removed, see #660. I have opened an issue for .cid, #661.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants