F-Droid can't build #147

licaon-kter · 2024-07-22T16:56:12Z

https://monitor.f-droid.org/builds/log/ua.com.radiokot.photoprism/43#site-footer

Is that coming to maven soon or should we build it from source instead?

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/ce82a52e3d2d08ae7af2b0b34d654d4a04fa442c

Radiokot · 2024-07-22T17:35:48Z

Hi Licaon Kter, thank you for reporting the failure.
ua.com.radiokot:offline-license-key:1.0.0 dependency is hosted on Jitpack, and it's been in the app since April.
I don't know why it didn't resolve, as the package is definitely available:
https://jitpack.io/ua/com/radiokot/offline-license-key/1.0.0/build.log
https://jitpack.io/ua/com/radiokot/offline-license-key/1.0.0/offline-license-key-1.0.0.jar

Radiokot · 2024-08-13T15:30:22Z

Version 44 built successfully
https://monitor.f-droid.org/builds/log/ua.com.radiokot.photoprism/44#site-footer

linsui · 2024-09-29T06:52:44Z

Reproducible build failed.
ua.com.radiokot.photoprism-1.31.0.apk.html.zip

Maybe clean the cache and rebuild? Could you please take a look? Thanks!

Radiokot · 2024-09-29T07:22:53Z

F-Droid, oh, F-Droid 😄
I've cleaned the local build cache and re-built the APK. The updated file is attached to the release:
https://github.com/Radiokot/photoprism-android-client/releases/download/1.31.0(46)/ua.com.radiokot.photoprism-1.31.0.apk
@linsui can you please re-run the pipeline?

linsui · 2024-09-29T07:53:35Z

ua.com.radiokot.photoprism-1.31.0(1).apk.html.zip
Now there is only a small diff. Any idea?

Radiokot · 2024-09-29T08:10:57Z

I accidentally added an extra line break to the class source code, maybe that's why the lines are offset by 1, although I thought the compiler ignores all the line breaks and spaces.
@linsui please, try the updated APK:
https://github.com/Radiokot/photoprism-android-client/releases/download/1.31.0(46)/ua.com.radiokot.photoprism-1.31.0.apk

linsui · 2024-09-29T08:13:44Z

It works, thanks!

licaon-kter · 2024-11-12T10:18:31Z

and again: https://gitlab.com/fdroid/checkupdates-bot-fdroiddata/-/jobs/8327688100#L659

diff log is really small:

│   --- ua.com.radiokot.photoprism-1.32.0/smali_classes3/ua/com/radiokot/photoprism/features/gallery/view/model/GalleryViewModel.smali
├── +++ ua.com.radiokot.photoprism_48/smali_classes3/ua/com/radiokot/photoprism/features/gallery/view/model/GalleryViewModel.smali
│ @@ -1040,33 +1040,31 @@
│      invoke-direct {p0}, Lua/com/radiokot/photoprism/features/gallery/view/model/GalleryViewModel;->getStateDefaultSearchConfig()Lua/com/radiokot/photoprism/features/gallery/data/model/SearchConfig;
│  
│      move-result-object v0
│  
│      iput-object v0, p0, Lua/com/radiokot/photoprism/features/gallery/view/model/GalleryViewModel;->currentSearchConfig:Lua/com/radiokot/photoprism/features/gallery/data/model/SearchConfig;
│  
│      .line 204
│ +    iget-object v1, p0, Lua/com/radiokot/photoprism/features/gallery/view/model/GalleryViewModel;->mediaRepositoryChanges:Lio/reactivex/rxjava3/subjects/BehaviorSubject;
│ -    iget-object v0, p0, Lua/com/radiokot/photoprism/features/gallery/view/model/GalleryViewModel;->mediaRepositoryChanges:Lio/reactivex/rxjava3/subjects/BehaviorSubject;
│  
│      .line 205
│ +    new-instance v2, Lua/com/radiokot/photoprism/features/gallery/view/model/GalleryViewModel$MediaRepositoryChange$ResetToInitial;
│ -    new-instance v1, Lua/com/radiokot/photoprism/features/gallery/view/model/GalleryViewModel$MediaRepositoryChange$ResetToInitial;
│  
│      .line 206
│ +    iget-object v3, p0, Lua/com/radiokot/photoprism/features/gallery/view/model/GalleryViewModel;->galleryMediaRepositoryFactory:Lua/com/radiokot/photoprism/features/gallery/data/storage/SimpleGalleryMediaRepository$Factory;
│ -    iget-object v2, p0, Lua/com/radiokot/photoprism/features/gallery/view/model/GalleryViewModel;->galleryMediaRepositoryFactory:Lua/com/radiokot/photoprism/features/gallery/data/storage/SimpleGalleryMediaRepository$Factory;
│  
│ +    invoke-virtual {v3, v0}, Lua/com/radiokot/photoprism/features/gallery/data/storage/SimpleGalleryMediaRepository$Factory;->get(Lua/com/radiokot/photoprism/features/gallery/data/model/SearchConfig;)Lua/com/radiokot/photoprism/features/gallery/data/storage/SimpleGalleryMediaRepository;
│ -    iget-object v3, p0, Lua/com/radiokot/photoprism/features/gallery/view/model/GalleryViewModel;->currentSearchConfig:Lua/com/radiokot/photoprism/features/gallery/data/model/SearchConfig;
│  
│ +    move-result-object v0
│ -    invoke-virtual {v2, v3}, Lua/com/radiokot/photoprism/features/gallery/data/storage/SimpleGalleryMediaRepository$Factory;->get(Lua/com/radiokot/photoprism/features/gallery/data/model/SearchConfig;)Lua/com/radiokot/photoprism/features/gallery/data/storage/SimpleGalleryMediaRepository;
│ -
│ -    move-result-object v2
│  
│      .line 205
│ +    invoke-direct {v2, v0}, Lua/com/radiokot/photoprism/features/gallery/view/model/GalleryViewModel$MediaRepositoryChange$ResetToInitial;-><init>(Lua/com/radiokot/photoprism/features/gallery/data/storage/SimpleGalleryMediaRepository;)V
│ -    invoke-direct {v1, v2}, Lua/com/radiokot/photoprism/features/gallery/view/model/GalleryViewModel$MediaRepositoryChange$ResetToInitial;-><init>(Lua/com/radiokot/photoprism/features/gallery/data/storage/SimpleGalleryMediaRepository;)V
│  
│      .line 204
│ +    invoke-virtual {v1, v2}, Lio/reactivex/rxjava3/subjects/BehaviorSubject;->onNext(Ljava/lang/Object;)V
│ -    invoke-virtual {v0, v1}, Lio/reactivex/rxjava3/subjects/BehaviorSubject;->onNext(Ljava/lang/Object;)V
│  
│      return-void
│  .end method
│  
│  .method private final subscribeToFastScroll()V
│      .locals 7

Radiokot · 2024-11-12T12:14:11Z

Hi, I've cleaned the local build cache and re-built the APK. The updated file is attached to the release:
https://github.com/Radiokot/photoprism-android-client/releases/tag/1.32.0(48)
@licaon-kter @linsui can you please re-run the build?

licaon-kter · 2024-11-12T13:16:19Z

same fail, same diff log :(

Radiokot · 2024-11-12T13:40:00Z

@licaon-kter Ok, I have no idea on the cause of the issue, so now I just signed the APK from the fdroid build run artifacts and attached it to the release. Please, re-run. Thank you for your work 🤝🏻

licaon-kter · 2024-11-12T13:47:58Z

that's not how reproducibility works 🤷

Radiokot · 2024-11-12T14:33:19Z

@licaon-kter

The package built by F-Droid behaves as expected
There's a minor difference with the package built on my computer, perhaps caused by the way Kotlin is translated into Java bytecode
I, as a developer of the app, accept the package built by F-Droid as a correctly built one, like if it was built by CI

licaon-kter · 2024-11-13T12:39:34Z

@Radiokot yes, go ahead then 🤷

Radiokot · 2024-11-13T12:46:25Z

@licaon-kter please, re-run the job

licaon-kter · 2024-11-13T12:55:12Z

this was ok in the CI https://gitlab.com/fdroid/checkupdates-bot-fdroiddata/-/jobs/8340827080

but failed on the main server still: https://monitor.f-droid.org/builds/log/ua.com.radiokot.photoprism/48#site-footer

will loop locally to see if there's a pattern

licaon-kter · 2024-11-13T16:58:40Z

limiting to 6 cores was ok in my testing, eg. 22 cores was failing

will reopen if main server fails again: https://gitlab.com/fdroid/fdroiddata/-/commit/9437c790e215668c4f12cbf01b8a4b0aa4ad7aca

Radiokot · 2024-11-13T17:42:20Z

Thank you!

linsui · 2024-12-02T05:33:47Z

ua.com.radiokot.photoprism-1.33.0.apk.html.zip

Reproducible build failed. Maybe we need a clean rebuild?

Radiokot · 2024-12-02T06:58:33Z

@linsui clean rebuild hasn't worked for some time now.

The differences are negligible. I accept the package built by F-Droid as a correctly built one, I have signed it and attached to the release. Please, re-run the job. Thank you.

linsui · 2024-12-02T07:02:54Z

OK, thanks! But there must be something different that the diff is so large. Did you build it with openjdk 17?

linsui · 2024-12-02T07:50:40Z

Weird. I got the same apk. Could you please build the apk with openjdk 17, e.g. https://adoptium.net/temurin/releases/?

Radiokot · 2024-12-02T07:52:45Z

I'll try it for the next release, let's proceed with the APK built by F-Droid for now.

linsui · 2024-12-02T08:02:14Z

OK, thanks!

linsui · 2025-01-09T08:05:45Z

Reproducible build failed again.

Radiokot · 2025-01-09T08:44:35Z

Hi @linsui , that's unfortunate, this time it was built with JDK 17 as you suggested. Please, re-launch the task, I once again signed the F-Droid build and re-attached it to the release. Thank you.

linsui · 2025-01-09T09:10:32Z

Maybe a clean build helps. Your apk was not built from the tag.

Radiokot · 2025-01-09T09:21:49Z

What makes you think that?

linsui · 2025-01-09T09:24:14Z

The apk has a vcs info embeded. It points to the commit before the tag. So you built the apk before committing the last change.

Radiokot · 2025-01-09T09:26:45Z

I didn't know that. Could it cause the difference in dex files though? I build APK before putting a tag in order to smoke test it. If everything's fine, I update the changelog and put a tag, I don't change the sources 🤔

licaon-kter · 2025-01-09T09:41:09Z

See https://f-droid.org/docs/Reproducible_Builds/#vcs-info as the tree info (commit) ends up in the APK.

While we understand that developers build and test during their normal workflow, please upload release APKs built after tagging, from a clean tree at the actual tagged commit (i.e. without local changes or remaining artifacts from previous builds).

linsui · 2025-01-09T09:44:23Z

It shouldn't cause the dex diff. Did you clean the cache before building?

linsui · 2025-01-09T09:45:40Z

The diff is similiar though... It's still about smali_classes4/ua/com/radiokot/photoprism/features/gallery/view/model/GalleryViewModelGallery.smali.

licaon-kter · 2025-01-09T09:45:41Z

It shouldn't cause the dex diff.

right, but it's nice that it acts as a clue to how the build was made, it might help

Radiokot · 2025-01-09T09:49:24Z

Thanks guys, next time I'll build the APK after committing and tagging a version update. As for the clear cache, I run the Gradle clean and then build the main APK. If there are other cleaning routines which must be executed before building, please let me know 🙏🏻

Radiokot · 2025-01-16T09:13:36Z

Guys, please re-run the update job with the latest artifact attached to the release

linsui · 2025-01-16T09:36:25Z

Thanks!

licaon-kter · 2025-01-21T16:08:05Z

Looks like it fails to build on both buildserver: https://monitor.f-droid.org/builds/log/ua.com.radiokot.photoprism/50#site-footer

and for me locally

difflog:

│   --- ua.com.radiokot.photoprism-1.34.0/smali_classes4/ua/com/radiokot/photoprism/features/gallery/view/model/GalleryViewModelGallery.smali
├── +++ ua.com.radiokot.photoprism_50/smali_classes4/ua/com/radiokot/photoprism/features/gallery/view/model/GalleryViewModelGallery.smali
│ @@ -1005,31 +1005,33 @@
│      invoke-direct {p0}, Lua/com/radiokot/photoprism/features/gallery/view/model/GalleryViewModelGallery;->getStateDefaultSearchConfig()Lua/com/radiokot/photoprism/features/gallery/data/model/SearchConfig;
│  
│      move-result-object v0
│  
│      iput-object v0, p0, Lua/com/radiokot/photoprism/features/gallery/view/model/GalleryViewModelGallery;->currentSearchConfig:Lua/com/radiokot/photoprism/features/gallery/data/model/SearchConfig;
│  
│      .line 199
│ +    iget-object v0, p0, Lua/com/radiokot/photoprism/features/gallery/view/model/GalleryViewModelGallery;->mediaRepositoryChanges:Lio/reactivex/rxjava3/subjects/BehaviorSubject;
│ -    iget-object v1, p0, Lua/com/radiokot/photoprism/features/gallery/view/model/GalleryViewModelGallery;->mediaRepositoryChanges:Lio/reactivex/rxjava3/subjects/BehaviorSubject;
│  
│      .line 200
│ +    new-instance v1, Lua/com/radiokot/photoprism/features/gallery/view/model/GalleryViewModelGallery$MediaRepositoryChange$ResetToInitial;
│ -    new-instance v2, Lua/com/radiokot/photoprism/features/gallery/view/model/GalleryViewModelGallery$MediaRepositoryChange$ResetToInitial;
│  
│      .line 201
│ +    iget-object v2, p0, Lua/com/radiokot/photoprism/features/gallery/view/model/GalleryViewModelGallery;->galleryMediaRepositoryFactory:Lua/com/radiokot/photoprism/features/gallery/data/storage/SimpleGalleryMediaRepository$Factory;
│ -    iget-object v3, p0, Lua/com/radiokot/photoprism/features/gallery/view/model/GalleryViewModelGallery;->galleryMediaRepositoryFactory:Lua/com/radiokot/photoprism/features/gallery/data/storage/SimpleGalleryMediaRepository$Factory;
│  
│ +    iget-object v3, p0, Lua/com/radiokot/photoprism/features/gallery/view/model/GalleryViewModelGallery;->currentSearchConfig:Lua/com/radiokot/photoprism/features/gallery/data/model/SearchConfig;
│ -    invoke-virtual {v3, v0}, Lua/com/radiokot/photoprism/features/gallery/data/storage/SimpleGalleryMediaRepository$Factory;->get(Lua/com/radiokot/photoprism/features/gallery/data/model/SearchConfig;)Lua/com/radiokot/photoprism/features/gallery/data/storage/SimpleGalleryMediaRepository;
│  
│ +    invoke-virtual {v2, v3}, Lua/com/radiokot/photoprism/features/gallery/data/storage/SimpleGalleryMediaRepository$Factory;->get(Lua/com/radiokot/photoprism/features/gallery/data/model/SearchConfig;)Lua/com/radiokot/photoprism/features/gallery/data/storage/SimpleGalleryMediaRepository;
│ +
│ +    move-result-object v2
│ -    move-result-object v0
│  
│      .line 200
│ +    invoke-direct {v1, v2}, Lua/com/radiokot/photoprism/features/gallery/view/model/GalleryViewModelGallery$MediaRepositoryChange$ResetToInitial;-><init>(Lua/com/radiokot/photoprism/features/gallery/data/storage/SimpleGalleryMediaRepository;)V
│ -    invoke-direct {v2, v0}, Lua/com/radiokot/photoprism/features/gallery/view/model/GalleryViewModelGallery$MediaRepositoryChange$ResetToInitial;-><init>(Lua/com/radiokot/photoprism/features/gallery/data/storage/SimpleGalleryMediaRepository;)V
│  
│      .line 199
│ +    invoke-virtual {v0, v1}, Lio/reactivex/rxjava3/subjects/BehaviorSubject;->onNext(Ljava/lang/Object;)V
│ -    invoke-virtual {v1, v2}, Lio/reactivex/rxjava3/subjects/BehaviorSubject;->onNext(Ljava/lang/Object;)V
│  
│      return-void
│  .end method

Radiokot · 2025-01-21T16:15:14Z

I literally signed the APK built by F-Droid update checker on Jan 09 and attached it to the release as ua.com.radiokot.photoprism-1.34.0.apk. How can it have a diff in this case?

licaon-kter · 2025-01-21T16:23:53Z

...built by the F-Droid Gitlab CI user for verification at metadata merge time only.

Now that I look at it again, it's the same diff log as Nov 12 🤦

Radiokot · 2025-01-21T17:05:38Z

Never mind

Radiokot · 2025-02-04T13:22:20Z

The latest release artifact, version 1.35.0(51), has been built and signed by a GitHub action on Ubuntu 24.04 with Java 17 (Temurin). I wonder if there is going to be a diff this time.

licaon-kter · 2025-02-04T14:25:11Z

https://gitlab.com/fdroid/fdroiddata/-/commit/e6cfd8d5eb936e2f9b822985a4e3b9220ee7b4bf thanks

licaon-kter · 2025-02-04T15:39:05Z

Ah, one more thing @Radiokot https://gitlab.com/fdroid/fdroiddata/-/jobs/9037719640#L609

We find that there is a DependencyInfoBlock in your APK.

It's a Signing block added by AGP and encrypted with the Google public key so it can't be read by anyone else except Google. You can read more about it here and here.

While this was added a while ago, we were only enforcing it for new apps, and recently we started scanning updates too.

Could you please disable it with the following code?

android {
    dependenciesInfo {
        // Disables dependency metadata when building APKs.
        includeInApk = false
        // Disables dependency metadata when building Android App Bundles.
        includeInBundle = false
    }
}

Thanks!

Radiokot · 2025-02-05T08:27:54Z

Thanks, @licaon-kter

dependenciesInfo disabled for bundle and APK
New tag, 1.35.0(52) is published
The existing 1.35.0 release tag switched to 1.35.0(52)
Artifacts in the existing release re-built from the new tag, 1.35.0(52)

licaon-kter · 2025-02-05T09:56:02Z

thanks https://gitlab.com/fdroid/fdroiddata/-/commit/efb8e89a5e3a1a666d1617f9d2d3a32260f3a82a

licaon-kter added the bug Something isn't working label Jul 22, 2024

Radiokot closed this as completed Aug 13, 2024

Radiokot reopened this Sep 29, 2024

Radiokot added or can it? and removed bug Something isn't working labels Sep 29, 2024

Radiokot closed this as completed Sep 29, 2024

Radiokot reopened this Nov 13, 2024

licaon-kter closed this as completed Nov 13, 2024

licaon-kter reopened this Dec 2, 2024

licaon-kter closed this as completed Jan 16, 2025

licaon-kter reopened this Jan 21, 2025

licaon-kter closed this as completed Feb 4, 2025

licaon-kter reopened this Feb 4, 2025

licaon-kter closed this as completed Feb 5, 2025

F-Droid can't build #147

F-Droid can't build #147

Comments

licaon-kter commented Jul 22, 2024 • edited Loading

Radiokot commented Jul 22, 2024

Radiokot commented Aug 13, 2024

linsui commented Sep 29, 2024

Radiokot commented Sep 29, 2024

linsui commented Sep 29, 2024

Radiokot commented Sep 29, 2024

linsui commented Sep 29, 2024

licaon-kter commented Nov 12, 2024

Radiokot commented Nov 12, 2024

licaon-kter commented Nov 12, 2024

Radiokot commented Nov 12, 2024

licaon-kter commented Nov 12, 2024

Radiokot commented Nov 12, 2024

licaon-kter commented Nov 13, 2024

Radiokot commented Nov 13, 2024

licaon-kter commented Nov 13, 2024

licaon-kter commented Nov 13, 2024 • edited Loading

Radiokot commented Nov 13, 2024

linsui commented Dec 2, 2024

Radiokot commented Dec 2, 2024

linsui commented Dec 2, 2024

linsui commented Dec 2, 2024

Radiokot commented Dec 2, 2024

linsui commented Dec 2, 2024

linsui commented Jan 9, 2025

Radiokot commented Jan 9, 2025

linsui commented Jan 9, 2025

Radiokot commented Jan 9, 2025

linsui commented Jan 9, 2025

Radiokot commented Jan 9, 2025

licaon-kter commented Jan 9, 2025

linsui commented Jan 9, 2025

linsui commented Jan 9, 2025

licaon-kter commented Jan 9, 2025

Radiokot commented Jan 9, 2025

Radiokot commented Jan 16, 2025

linsui commented Jan 16, 2025

licaon-kter commented Jan 21, 2025

Radiokot commented Jan 21, 2025

licaon-kter commented Jan 21, 2025 • edited Loading

Radiokot commented Jan 21, 2025

Radiokot commented Feb 4, 2025

licaon-kter commented Feb 4, 2025

licaon-kter commented Feb 4, 2025

Radiokot commented Feb 5, 2025

licaon-kter commented Feb 5, 2025

licaon-kter commented Jul 22, 2024 •

edited

Loading

licaon-kter commented Nov 13, 2024 •

edited

Loading

licaon-kter commented Jan 21, 2025 •

edited

Loading