Incompatible with CoFHCore (for some reason)

[Desempregago]

Describe the bug

MultiMC Log

Video Proof

Minecraft version

1.16.5

Forge version

36.2.23

Mod version

2.2.3

Relevant log output

No response

[Rakambda]

Sources of that libraries are not public so I can't really do much.
Best is to mention that on the description page.

[Hekera]

The source is visible right here: https://github.com/CoFH/CoFHCore

[Rakambda]

Weird that they don't link it on their curse page

[Hekera]

Relevant method seems to be here: https://github.com/CoFH/CoFHCore/blob/de1378d4bba14500640dfb4e3d411a39322a6ec5/src/main/java/cofh/core/event/CoreCommonEvents.java#L93

[Rakambda]

Yeah seems like they have their own mending improvement. Event is cancelled at the end so if Forge decides that OverpoweredMending comes after Cofhcore then nothing can be done about it.

The only solution possible would be to increase the priority on my side, but I don't really know what that would mean for compatibility with other mods. It's like I force to take the lead.

[Hekera]

I will discuss this with them.

[Rakambda]

The important bit is probably this https://github.com/CoFH/CoFHCore/blob/8307b4bc7dda6461b620f3219f21687c286feb45/src/main/java/cofh/core/event/CoreCommonEvents.java#L116 where it stores xp in a container.

[Desempregago]

Well, you could increase the priority just to keep the underlying compatibility until the guys at CoFH do something about it.

[Rakambda]

You can try with that version for now. But I'm not a too big fan of setting the priority higher that way.
OverpoweredMending-1.16.5-2.2.3.zip