Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rudimentary way to specify other required bundles #364

Open
shawncplus opened this issue Oct 21, 2018 · 0 comments
Open

Rudimentary way to specify other required bundles #364

shawncplus opened this issue Oct 21, 2018 · 0 comments

Comments

@shawncplus
Copy link
Member

shawncplus commented Oct 21, 2018

Add a check-bundles command in util/ that will go through a specified (or each) bundle's package.json looking for a ranvierDeps property and verify that those bundles have been installed.

the ranvierDeps config should look like this:

"ranvierDeps": {
  "bundle-example-lib": "https://github.com/some/repo[#branch=master]"
}

The install-bundle should be updated to allow for the #branch part of a url.

I don't want to go into a whole situation of package locking or any of that insanity. Just warn if they're not installed and suggest installing with install-bundle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant