Skip to content

Commit

Permalink
Use simple copy for scratch-component.html
Browse files Browse the repository at this point in the history
Using the html webpack copy plugin meant that our scratch-component.html
page ended up with script tags loading both web-component.js and
PyodideWorker.js (corresponding to `entry` keys in webpack.config.js).
We don't need those in scratch-component.html and we want to rule out
whether their presence is causing the errors we're currently seeing when
deploying editor-ui using github actions.
  • Loading branch information
chrisroos committed Jan 13, 2025
1 parent b9302d2 commit 959b6cc
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -140,14 +140,10 @@ module.exports = {
template: "src/web-component.html",
filename: "web-component.html",
}),
new HtmlWebpackPlugin({
inject: "body",
template: "src/scratch-component.html",
filename: "scratch-component.html",
}),
new CopyWebpackPlugin({
patterns: [
{ from: "public", to: "" },
{ from: "src/scratch-component.html", to: "scratch-component.html" },
{ from: "scratch/dist/main.js", to: "scratch.js" },
// { from: "scratch/node_modules/scratch-gui/dist/static/blocks-media/default/*.svg", to: "static/blocks-media/default/[name][ext]" },
// { from: "scratch/node_modules/scratch-gui/dist/static/blocks-media/high-contrast/*.svg", to: "static/blocks-media/high-contrast/[name][ext]" },
Expand Down

0 comments on commit 959b6cc

Please sign in to comment.