WIP: Fix test warnings #1177
Draft
WIP: Fix test warnings #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the following warnings we're seeing when running the tests:
Warning: `ReactDOMTestUtils.act` is deprecated in favor of `React.act`.
Import `act` from `react` instead of `react-dom/test-utils`. See
https://react.dev/warnings/react-dom-test-utils for more info.
I initially attempted to upgrade to the latest version of
@testing-library/react (16.2.0) but that introduces other problems so
I'll stick with this for now.
chrisroos
had a problem deploying
to
previews/1177/merge
GitHub Actions
Failure
By following the instructions on https://react.dev/warnings/react-dom-test-utils.
chrisroos
had a problem deploying
to
previews/1177/merge
GitHub Actions
Failure
Warning: Failed prop type: The prop `children` is marked as required in
`ResizableWithHandle`, but its value is `undefined`. at children
(/home/chrisroos/Code/rpf/editor-ui/src/utils/ResizableWithHandle.js:42:11)
chrisroos
had a problem deploying
to
previews/1177/merge
GitHub Actions
Failure
This avoids the following warning. Although the test setup adds a div
with id of "app", that's not in the dom at the point the InputModal
attempts to find it with `document.querySelector("#app")` and
`document.getElementById("app")`.
console.error
Warning: react-modal: App element is not defined. Please use `Modal.setAppElement(el)` or set `appElement={el}`. This is needed so screen readers don't see main content when modal is opened. It is not recommended, but you can opt-out by setting `ariaHideApp={false}`.
chrisroos
had a problem deploying
to
previews/1177/merge
GitHub Actions
Failure
chrisroos
force-pushed
the
fix-test-warnings
branch
from
09260eb to
cf8cbf3
Compare
This commit identifies all the tests that emit warnings and/or errors. I intend to work through them to fix the warnings/errors properly and then I can remove this commit.
chrisroos
force-pushed
the
fix-test-warnings
branch
from
cf8cbf3 to
75cab7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.