-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rolling list of comments and issues in book #10
Comments
"Rendering a complex scene takes a long time and this get worse as the rendered scenes get complex." Missing a word? "This can get worse"? "this gets worse"? |
"Notably, modern GPUs are now equipped with hardware cores dedicated to ray tracing." Maybe don't mention this functionality as I don't believe we'll be using these cores? |
"... The accompanying code intentionally avoids hardware ray tracing APIs that are present on newer GPU models, instead focusing on implementing the same functionality on a programmable GPU unit using a shading language. " If I was brand new to GPUs what exactly a shading language is would not be clear to me. Nor would it be clear if a shading language can't use the ray tracing APIs. perhaps elaborate: I'm not sure what would be best here. play with it. |
" In my examples I use an API based on WebGPU, which I think maps well to all modern graphics APIs. " perhaps mention WebGPUs comparative ease of use |
"I tried to avoid external dependencies as much as possible except for the following: " to "I tried to avoid external dependencies as much as possible but I decided to include the following:" |
You my want to drop the There's value in a "If you don't care about windowing you can use the prebuilt template in |
You need to point the reader at resources for rust beginners. Two important things to point to
You may not need to make these assumptions of your audience (and assume that they can figure all of this stuff on their own), but it's reasonable to assume that your audience is not an expert in rust, even if they may be an familiar with graphics concepts |
leads to
needs to have
|
I'm running on linux and wayland. I ran into this: rust-windowing/winit#3164: Which is a known quirk on wayland: https://docs.rs/winit/latest/winit/platform/wayland/index.html
the brute force solution of forcing X11 fixed the no windows bug
But I get a thread panic regardless of which windowing system I use:
I'll work backward to figure out that one. It's possibly a driver bug |
"Interpolating from blue towards a reddish color instead of pure white can resemble twilight. Give vec3(1., 5. 0.3)) a try. " Give vec3(1., 0.5, 0.3)) ? |
I'll add a serious of rolling issues in the book
The text was updated successfully, but these errors were encountered: