Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Proper error handling for Rect #23

Open
mauro-balades opened this issue Aug 20, 2022 · 5 comments
Open

[REQUEST] Proper error handling for Rect #23

mauro-balades opened this issue Aug 20, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mauro-balades
Copy link
Member

No description provided.

@tokorv
Copy link
Member

tokorv commented Aug 20, 2022

Hi Mauro, could you please elaborate to what you're referring to exactly? Maybe give some examples of what you were think of?

@mauro-balades
Copy link
Member Author

Hi Mauro, could you please elaborate to what you're referring to exactly? Maybe give some examples of what you were think of?

Hi, Alexander Tokorv The Second. I hope you are having a splendid day. Of course, I can elaborate more! This issue has been opened from a discussion in #10 . My request is to add a "real" exception handler in the backend and in the frontend.

the syntax may be the typical C++ syntax such as:

try {} catch () {}

The idea is to allow users to catch/create runtime/compile(time) errors.

@tokorv
Copy link
Member

tokorv commented Aug 20, 2022

Thanks for much for considering to contribute to this project!
We have looked into try and except handling before, but struggled to find a solution with minimal overhead.
We are glad you've come aboard to help improve the project.
I look forward to you future issues/pull requests.

Thanks
Tokorv

@tokorv tokorv pinned this issue Aug 20, 2022
@tokorv tokorv added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Aug 20, 2022
@tokorv tokorv self-assigned this Aug 20, 2022
@mauro-balades
Copy link
Member Author

Here is what CPP is doing. As you can see, C++ uses external functions for things such as throwing, catching, etc... For LLVM to catch the exception, we need the use of invoke. But how do I know where to use invoke? One way to solve this is by checking if the function throws an exception of if the user declares that the function will throw an exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants